Align created property with DI spec (making it optional) #86
Conversation
Wind4Greg
requested review from
msporny,
dmitrizagidulin and
seabass-labrax
as code owners
| The `created` property of the proof MUST be an [[XMLSCHEMA11-2]] | ||
| formatted date string. |
There was a problem hiding this comment.
This doesn't make the created property optional; it drops all reference to it. I would expect something like this —
| The `created` property of the proof MUST be an [[XMLSCHEMA11-2]] | |
| formatted date string. | |
| The `created` property of the proof is OPTIONAL; if present, it MUST be an | |
| [[XMLSCHEMA11-2]] formatted date string. |
There was a problem hiding this comment.
I think it's fine to remove it... the spec text states that the base requirements come from DI, and the requirements listed here are ADDITIONAL requirements. IOW, if we kept your text @TallTed -- we'd be duplicating normative statements across DI and the EdDSA cryptosuite.
There was a problem hiding this comment.
OK; I overlooked that this was replicating DI.
There was a problem hiding this comment.
(But I submit that the title of this PR should be changed accordingly.)
msporny
changed the title
|
Editorial, multiple reviews, changes requested (but not made with agreement), no objections, merging. |
msporny
added
normative
This PR addresses issue #73. It does this by basing the DataIntegrityProof proof contents on those in the Data Integrity specification where the created attribute is optional.
Preview | Diff