Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure additional custom proof options provided via proof are included in the proof configuration #74

Closed
dlongley opened this issue Jan 2, 2024 · 3 comments
Closed

Ensure additional custom proof options provided via proof are included in the proof configuration #74

dlongley opened this issue Jan 2, 2024 · 3 comments
Assignees
@msporny
Labels
CR1 normative This item is a substantive or normative change. pr exists A Pull Request exists to address this issue.

Comments

@dlongley
Copy link
Contributor

dlongley commented Jan 2, 2024

When creating a proof, other custom proof fields might be given, but it looks like the proof configuration algorithm will not include these -- and it should.
@msporny msporny added normative This item is a substantive or normative change. CR1 labels Feb 9, 2024
@msporny msporny self-assigned this Jun 28, 2024
@msporny
Copy link
Member

msporny commented Jun 30, 2024 •
edited
Loading

This spec seems to be using the "old language" as well @Wind4Greg -- thoughts?

@Wind4Greg
Copy link
Contributor

Wind4Greg commented Jul 1, 2024 •
edited
Loading

@msporny, Let me get a PR out to fix on Monday.

@Wind4Greg Wind4Greg mentioned this issue Jul 1, 2024
Merged
@msporny msporny added wontfix This will not be worked on pr exists A Pull Request exists to address this issue. and removed ready for pr wontfix This will not be worked on labels Jul 30, 2024
@msporny
Copy link
Member

msporny commented Jul 30, 2024

PR #88 has been merged to address this issue. Closing.

@msporny msporny closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msporny msporny

Labels
CR1 normative This item is a substantive or normative change. pr exists A Pull Request exists to address this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@msporny @dlongley @Wind4Greg