Incorporate additional custom proof options #88
Conversation
…nput and update the procedures accordingly.
Wind4Greg
requested review from
msporny,
dmitrizagidulin and
seabass-labrax
as code owners
…ovements. Co-authored-by: Ted Thibodeau Jr <[email protected]>
| Set <var>proofConfig</var>.<var>verificationMethod</var> to | ||
| <var>options</var>.<var>verificationMethod</var>. | ||
| Set |proofConfig|.<var>@context </var>to | ||
| |unsecuredDocument|.<var>@context</var>. |
There was a problem hiding this comment.
This seems like it was erroneously copied from the jcs cryptosuite ... am I just misreading it? It looks like it might be in the wrong place because I didn't see it in the jcs cryptosuite in this spec.
There was a problem hiding this comment.
I think this is right. Before we can canonize the proofConfig we need to add @context. Right? This was something that we had to fix way back when I started figuring out how to generate the test vectors...
Co-authored-by: Dave Longley <[email protected]>
Co-authored-by: Dave Longley <[email protected]>
|
@Wind4Greg merge conflicts, please fix. @dlongley and @Wind4Greg, I can't tell if we still need to make changes on this PR or not. |
|
@msporny fixed merge conflicts as best I could. Don't know if I dropped some punctuation updates or not. A lot of small editorial updates have been happening. |
| Set <var>proofConfig</var>.<var>verificationMethod</var> to | ||
| <var>options</var>.<var>verificationMethod</var>. | ||
| Set |proofConfig|.<var>@context </var>to | ||
| |unsecuredDocument|.<var>@context</var>. |
|
Normative, multiple reviews, changes requested and made, no objections, merging. |
This PR addresses issue #74. It updates the proof configuration procedures to use a clone of the options input and then updates the procedures accordingly.
Preview | Diff