-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix B.3 Representation: Ed25519Signature2020 test vectors #76
Conversation
iherman marked as non substantive for IPR from ash-nazg. |
@filip26, thanks for the PR -- do you know if these updates align w/ other implementations (I imagine they do since you're passing the test suite?) @Wind4Greg, what's going on with these test vectors? Are these updates correct? |
@msporny Without a proper I expect no issues for other implementations, on the contrary, without the right context, the result using example context is not verifiable, i.e. a proof type is unknown to a verifier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified these against my vectors. Thanks @filip26!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks like what I asked for in #75. I haven't checked this against our implementation but it definitely looks better.
Adds missing
@context
https://w3id.org/security/suites/ed25519-2020/v1
toEd25519Signature2020
test vectors. Proof canonical form, hash, and signature are re-computed.It's related to, but does not close, issue #75
Preview | Diff