Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the RDF Canon references to the official one #83

Merged
merged 2 commits into from
Jun 30, 2024

Conversation

iherman
Copy link
Member

@iherman iherman commented Jun 9, 2024

The PR proposes a solution for #78


Preview | Diff

@iherman iherman added the editorial This item is editorial in nature. label Jun 9, 2024
@iherman
Copy link
Member Author

iherman commented Jun 9, 2024

@msporny @Wind4Greg the github action reported errors in the markup which are not relevant to the changes I have made (I believe); I am not sure what the problems are. The html validator reports these errors on the 'main' branch as well.

@Wind4Greg
Copy link
Contributor

Wind4Greg commented Jun 10, 2024

@iherman and @msporny I'll take a look at the HTML validation errors. I saw something like this before and thought I fixed it. Hmm, just sync'd my local repo to main then uploaded html to the w3c validator and only got a few warnings, but no errors. Not sure what is happening.

Looked at the PR error report. These were things I previously fixed. Did you sync your fork to the latest?

@msporny msporny merged commit 0fa95aa into main Jun 30, 2024
2 checks passed
@msporny msporny deleted the rdf-canon-reference branch June 30, 2024 16:13
@msporny
Copy link
Member

msporny commented Jun 30, 2024

Editorial, multiple reviews, changes requested and made, no objections, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial This item is editorial in nature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants