Unify error codes and error handling language #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing and conveying errors.
Wind4Greg
requested review from
msporny,
dmitrizagidulin and
seabass-labrax
as code owners
TallTed
requested changes
Jun 24, 2024
…date wording for self consistency. Co-authored-by: Ted Thibodeau Jr <[email protected]>
iherman
approved these changes
Jun 28, 2024
dlongley
approved these changes
Jun 28, 2024
…i-eddsa into error-code-update
|
@TallTed please check this again. I got weird merge conflicts when I added links for the error codes (to the DI spec) and don't know if I lost some of the edits. |
msporny
approved these changes
Jun 30, 2024
|
Normative, multiple reviews, changes requested and made, no objections, merging. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #82.
It updates the document to use three main error codes (PROOF_TRANSFORMATION_ERROR, PROOF_GENERATION_ERROR, and PROOF_VERIFICATION_ERROR. ) and adds appropriate language on raising and conveying errors where appropriate.
Preview | Diff