-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitespace cleanup and phrasing rationalization #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallTed
requested review from
msporny,
dmitrizagidulin,
Wind4Greg and
seabass-labrax
as code owners
July 2, 2024 22:57
Wind4Greg
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TallTed this is a good editorial clean up.
msporny
reviewed
Jul 10, 2024
msporny
reviewed
Jul 10, 2024
dlongley
approved these changes
Jul 12, 2024
msporny
approved these changes
Jul 15, 2024
msporny
force-pushed
the
TallTed-patch-cleanup-20240702
branch
from
July 15, 2024 15:54
4d0fade
to
1898f4e
Compare
Co-authored-by: Manu Sporny <[email protected]>
Co-authored-by: Dave Longley <[email protected]>
msporny
force-pushed
the
TallTed-patch-cleanup-20240702
branch
from
July 15, 2024 15:56
1898f4e
to
8d9f007
Compare
Editorial, multiple reviews, changes requested and made, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry this touches a LOT of the doc. I started with trying to fix if/then phrasing, and got distracted by the whitespace. The changed files should look much smaller if you hide whitespace changes.
if
statements use consistent phrasingPreview | Diff