Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving explanation of SD-JWT #215

Closed
wants to merge 4 commits into from

Conversation

David-Chadwick
Copy link
Contributor

@David-Chadwick David-Chadwick commented Dec 31, 2023

This adds clarifying text and further describes example 1 to the reader


Preview | Diff

This adds clarifying text and further describes example 1 to the reader
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
David-Chadwick and others added 3 commits January 6, 2024 15:45
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@selfissued
Copy link
Collaborator

If you'd like the working group to discuss this topic, please open an issue for the discussion. Before a PR is created, we normally first obtain working group consensus on any change to be made. Please close this PR until such time as there is working group consensus to make a change. Thank you.

@David-Chadwick
Copy link
Contributor Author

the issue is already there. It is #199
This is the PR to resolve it.

@decentralgabe
Copy link
Collaborator

Closing, as we're headed in the direction of including all of JOSE.

@David-Chadwick
Copy link
Contributor Author

This PR should still be relevant when JOSE is added back, since what it does is describe the SD-JWT example. Unless the SD-JWT example is to be removed, then I would kindly ask you to re-open this PR.

@decentralgabe
Copy link
Collaborator

@David-Chadwick it appears that half the language is relevant and another half is not. Is your preference to amend this PR or work on a new one?

@David-Chadwick
Copy link
Contributor Author

As discussed in one of our recent weekly calls, the script that produces the multi-tab format for SD-JWT is faulty (e.g. the Disclosed tab is faulty). So obviously the text that describes this tab is not correct. Once the script has been fixed and the tabs amended, then the PR can be updated to describe each of the tabs. I am happy to update the PR once the revised script is available.

@decentralgabe
Copy link
Collaborator

Ok, I don't know much about this script but I'm happy to re-open the PR until then.

@decentralgabe decentralgabe reopened this Jan 25, 2024
@decentralgabe
Copy link
Collaborator

related to #214

@decentralgabe
Copy link
Collaborator

Closing this as it is superseded by #241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants