-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving explanation of SD-JWT #215
Conversation
This adds clarifying text and further describes example 1 to the reader
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
If you'd like the working group to discuss this topic, please open an issue for the discussion. Before a PR is created, we normally first obtain working group consensus on any change to be made. Please close this PR until such time as there is working group consensus to make a change. Thank you. |
the issue is already there. It is #199 |
Closing, as we're headed in the direction of including all of JOSE. |
This PR should still be relevant when JOSE is added back, since what it does is describe the SD-JWT example. Unless the SD-JWT example is to be removed, then I would kindly ask you to re-open this PR. |
@David-Chadwick it appears that half the language is relevant and another half is not. Is your preference to amend this PR or work on a new one? |
As discussed in one of our recent weekly calls, the script that produces the multi-tab format for SD-JWT is faulty (e.g. the Disclosed tab is faulty). So obviously the text that describes this tab is not correct. Once the script has been fixed and the tabs amended, then the PR can be updated to describe each of the tabs. I am happy to update the PR once the revised script is available. |
Ok, I don't know much about this script but I'm happy to re-open the PR until then. |
related to #214 |
Closing this as it is superseded by #241 |
This adds clarifying text and further describes example 1 to the reader
Preview | Diff