Remove YAML; add disclosures to SD-JWT examples; add protected headers #272
+155
−199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 15, 2024 21:02
selfissued
approved these changes
May 16, 2024
TallTed
requested changes
May 16, 2024
decentralgabe
commented
May 16, 2024
Co-authored-by: Ted Thibodeau Jr <[email protected]>
|
Not sure if/how to comment here but from a quick look at the Preview the examples don't look to be self consistent or syntactically correct. |
|
@bc-pi I see some issues too, I'll fix them and comment here when they're addressed. |
bc-pi
suggested changes
May 16, 2024
added 2 commits
May 16, 2024 14:58
|
@bc-pi it's rare I screw up so bad I leave someone speechless 😂 - my apologies I've fixed the code, if you refresh https://pr-preview.s3.amazonaws.com/w3c/vc-jose-cose/pull/272.html you'll see it in a better state. I may have to do some work on the nested disclosures, though I still believe this is an improvement. Hopefully it's at least to a place where you can articulate what's still not right. |
added 2 commits
May 16, 2024 15:31
|
#273 going to close and re-open ... rendering is not working as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #269 and replaces #270
Fix #271
Does not yet address #264 which I will take in a subsequent PR to add multiple tabs to the standalone SD-JWT example
for the combined example I feel this would be too much to display
Preview | Diff