Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phrasing, add spec links #281

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Fix phrasing, add spec links #281

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a8e535
fix 276 phrasing
Jun 27, 2024
3400a6b
pr comments
Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1479,7 +1479,8 @@ <h2 id="vcc-ld-json-jwt"><code>application/vc-ld+jwt</code></h2>
<code>application/vc-ld+jwt</code> Media Type specifically for
identifying a <a data-cite="JWT"></a>
with a payload
conforming to the Verifiable Credential Data Model.
conforming to the <a data-cite="VC-DATA-MODEL-2.0#verifiable-credentials">
Verifiable Credential Data Model</a>.
</p>
<table>
<tr>
Expand Down Expand Up @@ -1525,7 +1526,8 @@ <h2 id="vp-ld-json-jwt"><code>application/vp-ld+jwt</code></h2>
<code>application/vp-ld+jwt</code> Media Type specifically for
identifying a <a data-cite="JWT"></a>
with a payload
conforming to Verifiable Presentations.
conforming to the <a data-cite="VC-DATA-MODEL-2.0#verifiable-presentations">
Verifiable Presentation Data Model</a>.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not all that comfortable elevating "Verifiable Presentation Data Model" to a thing. The phrase is only used once in VCDM and then it's not capitalized.

It's more wordy, but I'd happier with something like "conforming to the Verifiable Presentations definition in the Verifiable Credential Data Model.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

</p>
<table>
<tr>
Expand Down Expand Up @@ -1571,7 +1573,8 @@ <h2 id="vc-ld-json-sd-jwt"><code>application/vc-ld+sd-jwt</code></h2>
<code>application/vc-ld+sd-jwt</code> Media Type specifically for
identifying a <a data-cite="SD-JWT"></a>
with a payload
conforming to the Verifiable Credential Data Model.
conforming to the <a data-cite="VC-DATA-MODEL-2.0#verifiable-credentials">
Verifiable Credential Data Model</a>.
</p>
<table>
<tr>
Expand Down Expand Up @@ -1617,7 +1620,8 @@ <h2 id="vp-ld-json-sd-jwt"><code>application/vp-ld+sd-jwt</code></h2>
<code>application/vp-ld+sd-jwt</code> Media Type specifically for
identifying a <a data-cite="SD-JWT"></a>
with a payload
conforming to Verifiable Presentations.
conforming to the <a data-cite="VC-DATA-MODEL-2.0#verifiable-presentations">
Verifiable Presentation Data Model</a>.
</p>
<table>
<tr>
Expand Down Expand Up @@ -1663,7 +1667,8 @@ <h2 id="vc-ld-json-cose"><code>application/vc-ld+cose</code></h2>
<code>application/vc-ld+cose</code> Media Type specifically for
identifying a COSE object [[RFC9052]]
with a payload
conforming to the Verifiable Credential Data Model.
conforming to the <a data-cite="VC-DATA-MODEL-2.0#verifiable-credentials">
Verifiable Credential Data Model</a>.
</p>
<table>
<tr>
Expand Down Expand Up @@ -1708,7 +1713,8 @@ <h2 id="vp-ld-json-cose"><code>application/vp-ld+cose</code></h2>
<code>application/vp-ld+cose</code> Media Type specifically for
identifying a COSE object [[RFC9052]]
with a payload
conforming to Verifiable Presentations.
conforming to the <a data-cite="VC-DATA-MODEL-2.0#verifiable-presentations">
Verifiable Presentation Data Model</a>.
</p>
<table>
<tr>
Expand Down
Loading