Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add language about selective disclosure considerations #308

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Conversation

decentralgabe
Copy link
Collaborator

@decentralgabe decentralgabe commented Sep 27, 2024

fix #285

examples to be subsequently fixed by w3c/respec-vc#41


Preview | Diff

@decentralgabe
Copy link
Collaborator Author

@msporny let me know if this addresses your concerns

index.html Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, though in my opinion, there could be more nuance here. Some of these properties are clearly required for consistent semantics (e.g., @context, type), others are really "up to the issuer". If the issuer doesn't mind a holder presenting without credential status, for example, I don't think that issuer MUST include it as mandatory. Who knows what the credential status is for here (e.g., it may not be for revocation).

So I don't think this language has to be as strict as it is, but since I'm not volunteering to come up with alternative language either, I approve as-is.

Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this do what you were thinking appropriate, @dlongley?

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@dlongley
Copy link
Contributor

dlongley commented Sep 30, 2024

@TallTed, yes, I can also accept SHOULD and leave the nuance to the issuer/implementer. I'd accept MUST for @context and type as well, but SHOULD is ok for all of them and I think is better for the other properties, IMO.

@decentralgabe
Copy link
Collaborator Author

Open for over a week. Changes accepted. Editorial approval. Merging!

@decentralgabe decentralgabe merged commit 183b998 into main Oct 4, 2024
2 checks passed
@decentralgabe decentralgabe deleted the fix-285 branch October 4, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a requirement on SD-JWT that credentialStatus should always be visible (plain).
5 participants