-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add language about selective disclosure considerations #308
Conversation
@msporny let me know if this addresses your concerns |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, though in my opinion, there could be more nuance here. Some of these properties are clearly required for consistent semantics (e.g., @context
, type
), others are really "up to the issuer". If the issuer doesn't mind a holder presenting without credential status, for example, I don't think that issuer MUST include it as mandatory. Who knows what the credential status is for here (e.g., it may not be for revocation).
So I don't think this language has to be as strict as it is, but since I'm not volunteering to come up with alternative language either, I approve as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this do what you were thinking appropriate, @dlongley?
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@TallTed, yes, I can also accept SHOULD and leave the nuance to the issuer/implementer. I'd accept MUST for |
Open for over a week. Changes accepted. Editorial approval. Merging! |
fix #285
examples to be subsequently fixed by w3c/respec-vc#41
Preview | Diff