Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vc-api tag. #7

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Remove vc-api tag. #7

merged 2 commits into from
Dec 4, 2023

Conversation

JSAssassin
Copy link
Contributor

@JSAssassin JSAssassin commented Dec 1, 2023

The tag is meant for running implementations against the VC API issuer and verifier tests, while the implementations here are run with other test suites(ecdsa, eddsa, Ed255192020Signature and vc-2.0), so it's not being used.

Copy link
Collaborator

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasoning is sound we'll need to clean up the README with vc-api stuff too.

@JSAssassin JSAssassin merged commit 9fa8bc7 into main Dec 4, 2023
2 checks passed
@JSAssassin JSAssassin deleted the remove-vc-api-tags branch December 4, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants