Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines update #129

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Guidelines update #129

wants to merge 22 commits into from

Conversation

rachaelbradley
Copy link
Contributor

@rachaelbradley rachaelbradley commented Nov 11, 2024

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for wcag3 ready!

Name Link
🔨 Latest commit 4796ec6
🔍 Latest deploy log https://app.netlify.com/sites/wcag3/deploys/6737c246670e9500083e731d
😎 Deploy Preview https://deploy-preview-129--wcag3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for wcag3-howtos canceled.

Name Link
🔨 Latest commit 4796ec6
🔍 Latest deploy log https://app.netlify.com/sites/wcag3-howtos/deploys/6737c246407aca0008fae486

Copy link

@hidde-logius hidde-logius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few nitpicks and thoughts

we don’t expect it to change. There are 5 levels:
<ul>
<li>Placeholder - we are thinking about the topic and plan to work on it in the next few months. </li>
<li>Exploratory - we have started work on this topic but still have many questions.</li>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency:

Suggested change
<li>Exploratory - we have started work on this topic but still have many questions.</li>
<li>Exploratory - we have started work on this topic, but still have many questions.</li>


<p>Ordinarily, exploratory content includes editor's notes listing concerns and questions for each item. Because this Guidelines section is very early in the process of working on WCAG 3.0, this editor's note covers the content of the entire section. Please consider all items in the list as exploratory at this point. It is a list of all possible topics for consideration. Not all items listed will become requirements.</p>
<p><strong> The following list is an initial set of potential guidelines and requirements that the working group will be exploring. The goal is to guide the next phase of work. They should be considered drafts and should not be considered as final content of WCAG 3</strong>.</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p><strong> The following list is an initial set of potential guidelines and requirements that the working group will be exploring. The goal is to guide the next phase of work. They should be considered drafts and should not be considered as final content of WCAG 3</strong>.</p>
<p><strong> The following list is an initial set of potential guidelines and requirements that the Working Group will be exploring. The goal is to guide the next phase of work. They should be considered drafts and should not be considered as final content of WCAG 3</strong>.</p>

</section>
<section class="provision" data-status="exploratory">
<h5>No cognitive tests</h5>
<p class="provision-text">Processes, including login/authentication, can be completed without puzzles, calculations, or other cognitive tests (essential exceptions would apply).</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this would be more clear if explicitly 'and':

Suggested change
<p class="provision-text">Processes, including login/authentication, can be completed without puzzles, calculations, or other cognitive tests (essential exceptions would apply).</p>
<p class="provision-text">Processes, including login and authentication, can be completed without puzzles, calculations, or other cognitive tests (essential exceptions would apply).</p>

or if we used just authentication:

Suggested change
<p class="provision-text">Processes, including login/authentication, can be completed without puzzles, calculations, or other cognitive tests (essential exceptions would apply).</p>
<p class="provision-text">Processes, including authentication, can be completed without puzzles, calculations, or other cognitive tests (essential exceptions would apply).</p>

</section>
<section class="provision" data-status="developing">
<h5>Custom indicator</h5>
<p class="provision-text">A custom focus indicator is used with sufficient size, change of contrast, adjacent contrast, distinct style and adjacecy. </p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

Suggested change
<p class="provision-text">A custom focus indicator is used with sufficient size, change of contrast, adjacent contrast, distinct style and adjacecy. </p>
<p class="provision-text">A custom focus indicator is used with sufficient size, change of contrast, adjacent contrast, distinct style and adjacency. </p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also confused by what it means for a focus indicator to have sufficient adjacency, is this clear enough?

</section>
<section class="provision" data-status="exploratory">
<h5>Restore focus</h5>
<p class="provision-text">When the focus is moved by the content into a temporary change of view (e.g. a modal), the focus is restored to its previous location when the view is restored.</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be easier to know where to move the focus if we reuse 'change of view' from the 'when'?

Suggested change
<p class="provision-text">When the focus is moved by the content into a temporary change of view (e.g. a modal), the focus is restored to its previous location when the view is restored.</p>
<p class="provision-text">When the focus is moved by the content into a temporary change of view (e.g. a modal), the focus is restored to where it was before the change of view.</p>

</section>
<section class="provision" data-status="exploratory">
<h5>Label in name</h5>
<p class="provision-text">The programmatic name includes the visual label.</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel something like this could make it clearer what to include:

Suggested change
<p class="provision-text">The programmatic name includes the visual label.</p>
<p class="provision-text">The programmatic name includes all of the text that is visibly part of the label.</p>

<p class="guideline-text">Users are not disadvantaged by algorithms.</p>
<section class="provision" data-status="exploratory">
<h5>Algorithm bias</h5>
<p class="provision-text">Algorithms (including AI) used are not biased against people with disabilities.</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel it's too unclear what we mean by “AI” here, it seems to refer to LLMs but they are not really algorithms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants