Use latest Ubuntu version for GitHub deploy workflow #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our deploy workflow was failing because it was using an older version of Ubuntu (which in turn had an older version of Python). Update our YML configuration to use the latest version. I considered pinning to a newer version but this matches both our other workflows and the w3c/spec-prod repo [1] so seems like a better choice. [1] https://github.com/w3c/spec-prod/blob/main/.github/workflows/docs.yml
xeenon
approved these changes
Feb 1, 2025
github-actions bot
added a commit
that referenced
this pull request
Feb 1, 2025
SHA: 4f7fad3 Reason: push, by xeenon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Feb 1, 2025
SHA: 4f7fad3 Reason: push, by xeenon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Thanks for catching and fixing this, Oliver! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our deploy workflow was failing because it was using an older version of Ubuntu (which in turn had an older version of Python). Update our YML configuration to use the latest version.
I considered pinning to a newer version but this matches both our other workflows and the w3c/spec-prod repo [1] so seems like a better choice.
I tested the change here: https://github.com/oliverdunk/webextensions/actions/runs/13080342576
[1] https://github.com/w3c/spec-prod/blob/main/.github/workflows/docs.yml