Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deliver Typink M2 #1245

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Deliver Typink M2 #1245

merged 1 commit into from
Feb 11, 2025

Conversation

sinzii
Copy link
Contributor

@sinzii sinzii commented Feb 3, 2025

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2420

@keeganquigley keeganquigley self-assigned this Feb 7, 2025
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sinzii thanks for the delivery and sorry for the delay. I'm running into some issues when using the CLI to create test contracts. Please see my evaluation for the exact errors. Do I need to do any config before building the example contracts? Thanks.

@sinzii
Copy link
Contributor Author

sinzii commented Feb 10, 2025

Hey @keeganquigley, thanks for giving it a try!

From your notes:

Getting an error when trying to build a test greeter contract:
The nearest package directory (/home/ubuntu/test) doesn't seem to be part of the project declared in /home/ubuntu.

  1. From the error message, seems like this is a yarn issue. Can you check if the /home/ubuntu is a project itself (having a package.json file or something), so yarn is trying to treat the newly created project as a sub-package. Can you remove the package.json file in /home/ubuntu and try again.
  2. What is the yarn version you're using? If (1) does not work, can you try upgrade it to a latest version?

I get a different error when trying the psp22 contract:
mkdir: cannot create directory ‘test’: File exists

From the error message, it seems there is already a test folder, can you try using a different name for the project?

Do I need to do any config before building the example contracts?

The example contract is already deployed on a real network as an example ready for you to try out in the UI, if you want deploy your own contract, please follow the instructions here in this tutorial to create a simple dapp!

Thank you!

@keeganquigley
Copy link
Contributor

Thanks @sinzii much appreciated. Yeah, it was a yarn issue. I'm not sure what the issue was, because I already had Yarn installed, and was able to install the CLI with it. Anyway, I spun up a new test box and started over using npm install --global yarn and then it worked without creating a package.json file. Thanks for your help!

I'm happy to pass the milestone, here is my final eval. Excellent work as usual!

@keeganquigley keeganquigley merged commit b1aa7aa into w3f:master Feb 11, 2025
6 checks passed
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

@sinzii
Copy link
Contributor Author

sinzii commented Feb 12, 2025

@keeganquigley Awesome, thanks a lot for your evaluation! I've also just submitted the invoice form.

@RouvenP
Copy link

RouvenP commented Feb 14, 2025

hi @sinzii we sent the payment today

@sinzii
Copy link
Contributor Author

sinzii commented Feb 15, 2025

Thank you @RouvenP! We have received the funds 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants