Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced static links #113

Merged
merged 2 commits into from
Dec 11, 2020
Merged

replaced static links #113

merged 2 commits into from
Dec 11, 2020

Conversation

jonasW3F
Copy link
Contributor

I replaced the link in the NPoS page and Babe.md.

I am not so sure about the link in README.md (see #112). It seems the absolute links might be necessary for GitHub?
@infinity0 Are that all links provided in #112, or should I look for more manually?

@jonasW3F jonasW3F self-assigned this Dec 10, 2020
@jonasW3F jonasW3F requested a review from infinity0 December 10, 2020 17:09
@infinity0
Copy link
Contributor

@jonasW3F looks great thanks! Yes that's all the links, and yes we can ignore the one in the README. I'd like to leave the ticket open for now though, for adding a test to the CI for this.

@infinity0 infinity0 merged commit c77783d into master Dec 11, 2020
@infinity0 infinity0 deleted the fix-static-links branch January 22, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants