Add WAGTAIL_AIRTABLE_TESTING flag to enable the mock API #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more robust than checking for `runtests.py` or `test` in the command line - this way the API will be mocked whenever the tests.settings module is in use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this line is used to check whether to use the mock Airtable API in place of the real one:
I spent far too long wondering why my tests were failing locally, because I was invoking them with
python ./runtests.py(which doesn't match the above test) instead ofpython runtests.py.This change makes this more robust, by introducing an explicit
WAGTAIL_AIRTABLE_TESTINGvariable in settings - so the mock will be used any time thetests.settingssettings module is active.