Apply richtext styles to markdown blocks and improve spacing of markdown/code blocks #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbayliss
commented
Feb 26, 2024
| @@ -1,6 +1,6 @@ | |||
| {% load wagtailcore_tags %} | |||
| <div class="grid"> | |||
| <div class="grid-align"> | |||
There was a problem hiding this comment.
Renamed because this is the only place .grid-align was used, so .code-block makes more sense
There was a problem hiding this comment.
I agree. This makes more sense. A little weird that it wasn't used elsewhere.
vossisboss
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
This looks good @kbayliss. I tested this with three previous blog posts that contain code blocks as well and they all look good. I'm not aware of any other ways we use the code-block styling outside of the blog, so this is seems good to go to me.
| @@ -1,6 +1,6 @@ | |||
| {% load wagtailcore_tags %} | |||
| <div class="grid"> | |||
| <div class="grid-align"> | |||
There was a problem hiding this comment.
I agree. This makes more sense. A little weird that it wasn't used elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR will:
RichTextBlocktoMarkDownBlock, which fixes display issues ofuland makes other elements display consistently withinMarkDownBlocks.MarkDownBlockandCodeBlockScreenshots
Both "Before" and "After" screenshots below are taken using the same StreamField which uses two approaches to achieve the same content:
Before
After