Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€:: (#1216) 가사 ν•˜μ΄λΌμ΄νŒ… 총 라인 계산 κΈ°μ€€ μˆ˜μ • #1217

Merged
merged 2 commits into from
Aug 24, 2024
Merged

πŸ”€:: (#1216) 가사 ν•˜μ΄λΌμ΄νŒ… 총 라인 계산 κΈ°μ€€ μˆ˜μ • #1217

merged 2 commits into from
Aug 24, 2024

Conversation

KangTaeHoon
Copy link
Contributor

@KangTaeHoon KangTaeHoon commented Aug 24, 2024 •
edited
Loading

πŸ’‘ λ°°κ²½ 및 κ°œμš”

  • 가사 ν•˜μ΄λΌμ΄νŒ… 총 라인 계산 κΈ°μ€€ μˆ˜μ •

Resolves: #1216

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • 가사 ν•˜μ΄λΌμ΄νŒ… 총 라인 계산 κΈ°μ€€ μˆ˜μ •

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 24, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions github-actions bot added the ⚑️ Performance μ„±λŠ₯ κ°œμ„  label Aug 24, 2024
@github-actions GitHub Actions
Copy link

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@KangTaeHoon

@KangTaeHoon KangTaeHoon merged commit 27c4dbd into release/3.0.0 Aug 24, 2024
5 checks passed
@KangTaeHoon KangTaeHoon deleted the 1216-modify-standard-in-lyric-highlighting-line-cnt branch August 24, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

@baekteun baekteun Awaiting requested review from baekteun baekteun is a code owner

Assignees

@KangTaeHoon KangTaeHoon

Labels
⚑️ Performance μ„±λŠ₯ κ°œμ„ 
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KangTaeHoon @yongbeomkwak