Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”€ :: (#1227) λ…Έλž˜ 상세에 μ§„μž… μ‹œ μ§„μž…μ  ꡬ뢄 없이 λ…Έλž˜ μƒμ„Έμ˜ 데이터λ₯Ό μ‚¬μš©ν•˜λ„λ‘ λ³€κ²½ #1228

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented Aug 25, 2024

πŸ’‘ λ°°κ²½ 및 κ°œμš”

λ…Έλž˜ 상세에 μ§„μž… μ‹œ μ§„μž…μ  ꡬ뢄 없이 λ…Έλž˜ μƒμ„Έμ˜ 데이터λ₯Ό μ‚¬μš©ν•˜λ„λ‘ λ³€κ²½

Resolves: #1227

πŸ“ƒ μž‘μ—…λ‚΄μš©

λ…Έλž˜ 상세에 μ§„μž… μ‹œ μ§„μž…μ  ꡬ뢄 없이 λ…Έλž˜ μƒμ„Έμ˜ 데이터λ₯Ό μ‚¬μš©ν•˜λ„λ‘ λ³€κ²½

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

ν˜Ήμ‹œλ‚˜ 단일 λ…Έλž˜λ₯Ό λ³΄μ—¬μ€˜μ•Όν•˜λŠ” 상황이 μƒκΈ°κ±°λ‚˜ ν•  μˆ˜λ„ μžˆμ„κ±°λΌ μƒκ°ν•΄μ„œ 일단 id, ids νŒŒλΌλ―Έν„°λŠ” 남기고 직접 μž¬μƒλͺ©λ‘ 데이터λ₯Ό λ³΄λ‚΄μ£ΌλŠ” μ‹μœΌλ‘œ λ°”κΏ”λ†“μ•˜μ–΄μš”.
ν˜Ήμ€ songDetailPresenter.present() μ΄λ ‡κ²Œ id없이보내면 μž¬μƒλͺ©λ‘ 데이터λ₯Ό μžλ™μœΌλ‘œ μ‚¬μš©ν•˜κ²Œ ν•  μˆ˜λ„ μžˆκ² λ„€μš”

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions github-actions bot added 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ ✨ Feature 피쳐 개발 labels Aug 25, 2024
Copy link

github-actions bot commented Aug 25, 2024

βœ… Successful finished SwiftLint

Copy link

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@baekteun

@baekteun baekteun merged commit 8e0a0ea into release/3.0.0 Aug 25, 2024
5 checks passed
@baekteun baekteun deleted the 1227-music-detail-data-using-playlist branch August 25, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ ✨ Feature 피쳐 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants