Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#1220) ํ”Œ๋ฆฌ ๋ณด๊ด€ํ•จ์— ์ž ๊ธˆ ์œ ๋ฌด ํ‘œ์‹œ #1229

Merged
merged 8 commits into from
Aug 25, 2024

Conversation

yongbeomkwak
Copy link
Member

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๋””์ž์ธ ๋ณ€๊ฒฝ์— ๋”ฐ๋ฅธ ๋ฐ˜์˜

Resolves: #1220

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • dto์™€ entity์— private์„ ์‚ฌ์šฉํ•˜๊ธฐ ์œ„ํ•ด ๋ช…์‹œ
  • close ์ž ๊ธˆ ์•„์ด์ฝ˜ ๋ฆฌ์†Œ์Šค ์ถ”๊ฐ€
  • cell์— imageview ์ถ”๊ฐ€ํ›„ hidden ์œ ๋ฌด์ฒ˜๋ฆฌ

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions github-actions bot added the 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ label Aug 25, 2024
Copy link

github-actions bot commented Aug 25, 2024

โœ… Successful finished SwiftLint

@github-actions github-actions bot added the โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ label Aug 25, 2024
Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@yongbeomkwak

baekteun
baekteun approved these changes Aug 25, 2024
@yongbeomkwak yongbeomkwak merged commit ef2a998 into release/3.0.0 Aug 25, 2024
2 checks passed
@yongbeomkwak yongbeomkwak deleted the 1220-display-lock-state-on-list-storage branch August 25, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants