Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#1230) λ…Έλž˜ μƒμ„Έμ—μ„œ μž¬μƒλͺ©λ‘ μ ‘κ·Ό μ‹œ μž¬μƒλͺ©λ‘ μžλ™ 슀크둀 #1250

Merged
merged 2 commits into from
Aug 28, 2024
Merged

πŸ”€ :: (#1230) λ…Έλž˜ μƒμ„Έμ—μ„œ μž¬μƒλͺ©λ‘ μ ‘κ·Ό μ‹œ μž¬μƒλͺ©λ‘ μžλ™ 슀크둀 #1250

merged 2 commits into from
Aug 28, 2024

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented Aug 28, 2024 •
edited
Loading

πŸ’‘ λ°°κ²½ 및 κ°œμš”

λ…Έλž˜ μƒμ„Έμ—μ„œ μž¬μƒλͺ©λ‘ μ ‘κ·Ό μ‹œ μž¬μƒλͺ©λ‘ μžλ™ 슀크둀

Resolves: #1230

πŸ“ƒ μž‘μ—…λ‚΄μš©

λ…Έλž˜ μƒμ„Έμ—μ„œ μž¬μƒλͺ©λ‘ μ ‘κ·Ό μ‹œ μž¬μƒλͺ©λ‘ μžλ™ 슀크둀

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

  • μŠ€ν¬λ‘€λ˜λŠ” μ• λ‹ˆλ©”μ΄μ…˜μ„ λ„£μ„κΉŒμš”? λ„ˆλ¬΄ κ·Έλƒ₯ ν›… λ°”λ€ŒλŠ” λŠλ‚Œμ΄λΌ μ•ˆλ„£μ—ˆλŠ”λ°
μ• λ‹ˆλ©”μ΄μ…˜ 넣은 버전)
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-28.at.20.33.08.mp4

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-28.at.20.30.47.mp4

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 28, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions github-actions bot added ✨ Feature 피쳐 개발 2️⃣ Priority: Medium μš°μ„ μˆœμœ„ 쀑 labels Aug 28, 2024
@github-actions GitHub Actions
Copy link

βœ… μ΄μŠˆμ™€ PR의 Labels 동기화λ₯Ό μ„±κ³΅ν–ˆμ–΄μš”!

@KangTaeHoon
Copy link
Contributor

μ• λ‹ˆλ©”μ΄μ…˜ μ—†λŠ”κ²Œ κΉ”λ”ν•΄μš”.

@baekteun baekteun merged commit e50f0d2 into release/3.0.0 Aug 28, 2024
5 checks passed
@baekteun baekteun deleted the 1230-auto-scroll-to-current-song-when-music-detail-to-playlist branch August 28, 2024 13:45
@github-actions github-actions bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@baekteun baekteun

Labels
2️⃣ Priority: Medium μš°μ„ μˆœμœ„ 쀑 ✨ Feature 피쳐 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baekteun @KangTaeHoon @yongbeomkwak