Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#1335) MusicDetailView crash ์ด์Šˆ ํ•ด๊ฒฐ #1336

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

baekteun
Copy link
Member

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

MusicDetailView crash ์ด์Šˆ ํ•ด๊ฒฐ

Resolves: #1335

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • MusicDetailView crash ์ด์Šˆ ํ•ด๊ฒฐ
  • songIDs๊ฐ€ ์ค‘๋ณต์œผ๋กœ ๋“ค์–ด์™€๋ฒ„๋ ค์„œ ์ค‘๋ณต ์ œ๊ฑฐ ์ „ index์™€ ํ›„์˜ index๊ฐ€ ๋‹ฌ๋ผ์„œ ์ƒ๊ธด ๋ฌธ์ œ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@baekteun baekteun linked an issue Jan 31, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Jan 31, 2025

โœ… Successful finished SwiftLint

@github-actions github-actions bot added 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ ๐Ÿž Bug ๋ฒ„๊ทธ ๊ด€๋ จ labels Jan 31, 2025
Copy link

โœ… ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@baekteun baekteun force-pushed the 1335-musicdetailview-crash branch from 708e183 to 119dbe9 Compare January 31, 2025 05:58
@baekteun baekteun changed the base branch from develop to 1337-ci-runner-upgrade January 31, 2025 05:59
Base automatically changed from 1337-ci-runner-upgrade to develop January 31, 2025 10:27
@baekteun baekteun merged commit a198eb6 into develop Jan 31, 2025
3 checks passed
@baekteun baekteun deleted the 1335-musicdetailview-crash branch January 31, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ ๐Ÿž Bug ๋ฒ„๊ทธ ๊ด€๋ จ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MusicDetailView crash ์ด์Šˆ
2 participants