🔀 :: (#525) AfterSearch VC를 ReactorKit으로 리팩합니다. #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongbeomkwak
requested review from
kimdaehee0824,
KangTaeHoon,
youn9k and
baekteun
as code owners
✅ Successful finished SwiftLint |
✅ 이슈와 PR의 Labels 동기화를 성공했어요! |
baekteun
reviewed
May 8, 2024
Projects/Features/SearchFeature/Sources/Reactors/AfterSearchReactor.swift
Outdated
Show resolved
Hide resolved
baekteun
reviewed
May 8, 2024
Projects/Features/SearchFeature/Sources/ViewControllers/AfterSearchViewController.swift
Outdated
Show resolved
Hide resolved
pre filtering Co-authored-by: baegteun <[email protected]>
…actor.swift Co-authored-by: baegteun <[email protected]>
baekteun
reviewed
May 8, 2024
Projects/Features/SearchFeature/Sources/Reactors/AfterSearchReactor.swift
Outdated
Show resolved
Hide resolved
…actor.swift Co-authored-by: baegteun <[email protected]>
baekteun
reviewed
May 9, 2024
Projects/Features/SearchFeature/Sources/ViewControllers/AfterSearchContentViewController.swift
Show resolved
Hide resolved
…ic/wakmusic-iOS into 525-refactor-after-search
5 tasks
KangTaeHoon
approved these changes
May 10, 2024
youn9k
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 배경 및 개요
After Search 쪽을 리액터 킷으로 리팩합니다.
Resolves: #525
📃 작업내용
-AfterSearchVC와 뷰모델을 리액터킷으로 리팩했습니다.
🙋♂️ 리뷰노트
✅ PR 체크리스트
XCConfig,노션,README)"API 개발 완료됐어요","XCConfig 값 추가되었어요")🎸 기타