🔀 :: (#530) 보관함탭을 ReactorKit으로 리팩합니다. #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongbeomkwak
requested review from
kimdaehee0824,
KangTaeHoon,
youn9k and
baekteun
as code owners
✅ Successful finished SwiftLint |
✅ Assign 자동 지정을 성공했어요! |
…ic/wakmusic-iOS into 530-refactory-storage-tab
baekteun
reviewed
May 11, 2024
Projects/Features/SignInFeature/Sources/Views/LoginWarningView.swift
Outdated
Show resolved
Hide resolved
Projects/Features/SignInFeature/Sources/Views/LoginWarningView.swift
Outdated
Show resolved
Hide resolved
Projects/Features/StorageFeature/Sources/Reactors/MyPlaylistReactor.swift
Outdated
Show resolved
Hide resolved
Projects/Features/StorageFeature/Sources/ViewControllers/StorageViewController.swift
Outdated
Show resolved
Hide resolved
Projects/Features/StorageFeature/Sources/Reactors/MyPlaylistReactor.swift
Outdated
Show resolved
Hide resolved
Projects/Features/StorageFeature/Sources/Reactors/MyPlaylistReactor.swift
Outdated
Show resolved
Hide resolved
| struct State { | ||
| var isEditing: Bool | ||
| var tabIndex: Int | ||
| @Pulse var isShowLoginAlert: Void |
There was a problem hiding this comment.
isShow면 bool일거같은데 Void니 값이 좀 어색한거같네요
There was a problem hiding this comment.
이벤트 신호만 주고 따로 변수에 값을 할당할 필요가 없었다고 느껴서 ??
baekteun
reviewed
May 11, 2024
KangTaeHoon
reviewed
May 11, 2024
Projects/UsertInterfaces/DesignSystem/Sources/Views/LoginWarningView.swift
Outdated
Show resolved
Hide resolved
Projects/UsertInterfaces/DesignSystem/Sources/Views/LoginWarningView.swift
Outdated
Show resolved
Hide resolved
KangTaeHoon
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 배경 및 개요
어지러운 보관함과 나의 플레이리스트를 리액터 킷으로 리팩합니다.
Resolves: #530
📃 작업내용
🙋♂️ 리뷰노트
✅ PR 체크리스트
XCConfig,노션,README)"API 개발 완료됐어요","XCConfig 값 추가되었어요")🎸 기타