Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#579) LyricDomain - API ๋ณ€๊ฒฝ์‚ฌํ•ญ ๋ฐ˜์˜ (์‹ ๊ทœ) #627

Merged
merged 15 commits into from
Jun 20, 2024

Conversation

KangTaeHoon
Copy link
Contributor

@KangTaeHoon KangTaeHoon commented Jun 18, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

LyricDomain - API ๋ณ€๊ฒฝ์‚ฌํ•ญ ๋ฐ˜์˜ (์‹ ๊ทœ)

Resolves: #579

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • LyricDomain ๋ชจ๋“ˆ ์ƒ์„ฑ
  • LyricDomain API ์ž‘์„ฑ
  • ๋ฐ์ฝ”๋ ˆ์ด์…˜ ๋ฐฑ๊ทธ๋ผ์šด๋“œ UseCase ์ƒ์„ฑ, ์ฃผ์ž…, ๋กœ์ง ์ถ”๊ฐ€

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

  • Swagger์— DTO ๋ช…์‹œ๊ฐ€ ์—†์œผ๋ฏ€๋กœ DTO๋Š” ๋ณ€๊ฒฝ๋  ์ˆ˜ ์žˆ์Œ.

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

Copy link

github-actions bot commented Jun 18, 2024

โœ… Successful finished SwiftLint

Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@KangTaeHoon

@yongbeomkwak yongbeomkwak added the 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ label Jun 20, 2024
@KangTaeHoon KangTaeHoon merged commit e88fe27 into develop Jun 20, 2024
3 checks passed
@KangTaeHoon KangTaeHoon deleted the 579-create-domain-lyric branch June 20, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LyricDomain - API ๋ณ€๊ฒฝ์‚ฌํ•ญ ๋ฐ˜์˜ (์‹ ๊ทœ)
3 participants