Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#637) μŠ€ν”Œλž˜μ‰¬(인트둜) μž„μ‹œ 둜직 제거 #644

Merged
merged 6 commits into from
Jun 23, 2024
Merged

πŸ”€ :: (#637) μŠ€ν”Œλž˜μ‰¬(인트둜) μž„μ‹œ 둜직 제거 #644

merged 6 commits into from
Jun 23, 2024

Conversation

KangTaeHoon
Copy link
Contributor

πŸ’‘ λ°°κ²½ 및 κ°œμš”

v3 λΌμš°ν„° μ΄μ „μœΌλ‘œ μΈν•œ μž„μ‹œ 둜직 제거

Resolves: #637

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • μž„μ‹œλ‘œμ§ 제거

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 22, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@KangTaeHoon

@KangTaeHoon KangTaeHoon changed the title πŸ”€ :: (637) μŠ€ν”Œλž˜μ‰¬(인트둜) μž„μ‹œ 둜직 제거 πŸ”€ :: (#637) μŠ€ν”Œλž˜μ‰¬(인트둜) μž„μ‹œ 둜직 제거 Jun 22, 2024
@KangTaeHoon KangTaeHoon merged commit 66e1fbf into develop Jun 23, 2024
3 checks passed
@KangTaeHoon KangTaeHoon deleted the 637-remove-temp-logic-splash branch June 23, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@youn9k youn9k youn9k approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@baekteun baekteun Awaiting requested review from baekteun baekteun is a code owner

Assignees

@KangTaeHoon KangTaeHoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

μŠ€ν”Œλž˜μ‰¬(인트둜) μž„μ‹œ 둜직 제거
3 participants
@KangTaeHoon @yongbeomkwak @youn9k