Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (668) PlayList ๋„ค์ด๋ฐ์„ Playlist๋กœ ๋ณ€๊ฒฝํ•ฉ๋‹ˆ๋‹ค. #669

Closed
wants to merge 2 commits into from

Conversation

yongbeomkwak
Copy link
Member

@yongbeomkwak yongbeomkwak commented Jun 25, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

PlayList ๋„ค์ด๋ฐ์— ๋Œ€ํ•œ ๋ชจํ˜ธํ•จ์ด ์žˆ์–ด Playlist๋„๋ฉ”์ธ ๊ด€๋ จ ๋„ค์ด๋ฐ ์ด์Šˆ๋ฅผ ๋ชจ๋‘ ๋ณ€๊ฒฝํ•ฉ๋‹ˆ๋‹ค.

Resolves: #668

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

PlayList -> Playlist

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

์ด๋ฆ„๋งŒ ๋ฐ”๋€Œ์–ด ํŒŒ์ผ ๋ณ€๊ฒฝ์ด ๋งŽ์œผ๋‹ˆ ํ…Œ์ŠคํŠธ๊ฐ€ ํ†ต๊ณผ๋˜๋ฉด ์Šน์ธ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

Copy link

github-actions bot commented Jun 25, 2024

โœ… Successful finished SwiftLint

Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@yongbeomkwak

@yongbeomkwak yongbeomkwak deleted the 668-second-refactor-playlist-domain branch June 25, 2024 12:59
yongbeomkwak added a commit that referenced this pull request Jun 26, 2024
๐Ÿ”€ :: (668) PlayList ๋„ค์ด๋ฐ์„ Playlist๋กœ ๋ณ€๊ฒฝํ•ฉ๋‹ˆ๋‹ค. #669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PlayList ๋„ค์ด๋ฐ์„ Playlist๋กœ ๋ณ€๊ฒฝํ•ฉ๋‹ˆ๋‹ค.
1 participant