Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#567) ๋‚ด ์ •๋ณด ํ™”๋ฉด ๊ตฌํ˜„ #675

Merged
merged 17 commits into from
Jun 27, 2024

Conversation

youn9k
Copy link
Member

@youn9k youn9k commented Jun 26, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๋‚ด ์ •๋ณด ํ™”๋ฉด์— ๋ณ€๊ฒฝ์‚ฌํ•ญ๋“ค์ด ์žˆ์–ด์„œ ๊ตฌํ˜„ํ–ˆ์Šต๋‹ˆ๋‹ค.
resolve #649

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

๋กœ๊ทธ์ธ ์ „ ๋กœ๊ทธ์ธ ํ›„
แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-06-26 แ„‹แ…ฉแ„’แ…ฎ 7 00 55 แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-06-26 แ„‹แ…ฉแ„’แ…ฎ 7 02 56

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

๋นจ๊ฐ„ ์  ๊ธฐ๋Šฅ ๊ตฌํ˜„์ด NoticeDomain์ž‘์—…์ด ์žˆ์–ด ๋ถ„๋ฆฌํ–ˆ์Šต๋‹ˆ๋‹ค. ํ•ด๋‹น ์ž‘์—… PR์—์„œ #567 #674 ๋™์‹œ์— ๋‹ซ์„๊ฒŒ์šฉ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

youn9k added 12 commits June 26, 2024 08:08
์„ฑ๊ณต ์‹œ status code ๊ฐ€ 204๋กœ ๋‚ด๋ ค์˜ด
Copy link

github-actions bot commented Jun 26, 2024

โœ… Successful finished SwiftLint

@github-actions github-actions bot added 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ labels Jun 26, 2024
Copy link

โœ… ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์„ฑ๊ณตํ–ˆ์–ด์š”!

Copy link
Member

@yongbeomkwak yongbeomkwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์„œ๋ฒ„์— ๋ฐ์ดํ„ฐ ๋ณด๋‚ผ ๋•Œ ReuqestDTO ํ˜•์‹์œผ๋กœ ํ•˜๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”

@youn9k youn9k merged commit b4daa15 into develop Jun 27, 2024
3 checks passed
@youn9k youn9k deleted the 567-implement-myinfo-feature branch June 27, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๋‚ด์ •๋ณด ํƒญ equalHandleTapped ๊ตฌํ˜„
3 participants