Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#668) ν”Œλ ˆμ΄λ¦¬μŠ€νŠΈ ꡬ독 / κ΅¬λ…ν•΄μ œ api 변경사항을 λ°˜μ˜ν•©λ‹ˆλ‹€. #689

Closed
wants to merge 2 commits into from
Closed

πŸ”€ :: (#668) ν”Œλ ˆμ΄λ¦¬μŠ€νŠΈ ꡬ독 / κ΅¬λ…ν•΄μ œ api 변경사항을 λ°˜μ˜ν•©λ‹ˆλ‹€. #689

wants to merge 2 commits into from

Conversation

yongbeomkwak
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

  • ν”Œλ ˆμ΄λ¦¬μŠ€νŠΈ ꡬ독 api 변경사항을 λ°˜μ˜ν•©λ‹ˆλ‹€.

Resolves: #668

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • api end point 및 HHTP method λ³€κ²½

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

κ΅¬ν˜„ μ‹œμ— κ³ λ―Όμ΄μ—ˆλ˜ 점듀 ν˜Ήμ€ νŠΉμ • 뢀뢄에 λŒ€ν•œ μ˜λ„κ°€ μžˆμ—ˆλ‹€λ©΄ PR 리뷰의 이해λ₯Ό 돕기 μœ„ν•΄ μ„œμˆ ν•΄μ£Όμ„Έμš”!

λ˜ν•œ λ¦¬λ·°μ–΄μ—κ²Œ νŠΉμ • 뢀뢄에 λŒ€ν•œ 집쀑 ν˜Ήμ€ μ½”λ©˜νŠΈ ν˜Ήμ€ μ§ˆλ¬Έμ„ μš”μ²­ν•˜λŠ” κ²½μš°μ— μž‘μ„±ν•˜λ©΄ μ’‹μ•„μš”!

e.g. μž‘μ—…μ„ 끝내야할 μ‹œκ°„μ΄ μ–Όλ§ˆ μ—†μ–΄ ν™•μž₯μ„±λ³΄λ‹€λŠ” λ™μž‘μ„ μœ„μ£Όλ‘œ λ§Œλ“€μ—ˆμ–΄μš”! κ°μ•ˆν•˜κ³  λ¦¬λ·°ν•΄μ£Όμ„Έμš”!

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions github-actions bot added 1️⃣ Priority: High μš°μ„ μˆœμœ„ 상 ⚑️ Simple κ°„λ‹¨ν•œ 변경사항 ⚑️ Performance μ„±λŠ₯ κ°œμ„  labels Jun 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@yongbeomkwak

@yongbeomkwak yongbeomkwak changed the title πŸ”€ :: (#668) μ˜€ν”ˆμ†ŒμŠ€ λΌμ΄μ„ μŠ€ 정리 πŸ”€ :: (#668) ν”Œλ ˆμ΄λ¦¬μŠ€νŠΈ ꡬ독 / κ΅¬λ…ν•΄μ œ api 변경사항을 λ°˜μ˜ν•©λ‹ˆλ‹€. Jun 27, 2024
@yongbeomkwak yongbeomkwak deleted the 668-update-playlist-subscribe-api branch June 27, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youn9k youn9k youn9k approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@KangTaeHoon KangTaeHoon Awaiting requested review from KangTaeHoon KangTaeHoon is a code owner

@baekteun baekteun Awaiting requested review from baekteun baekteun is a code owner

Assignees

@yongbeomkwak yongbeomkwak

Labels
1️⃣ Priority: High μš°μ„ μˆœμœ„ 상 ⚑️ Performance μ„±λŠ₯ κ°œμ„  ⚑️ Simple κ°„λ‹¨ν•œ 변경사항
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PlayList 넀이밍을 Playlist둜 λ³€κ²½ν•©λ‹ˆλ‹€.
2 participants
@yongbeomkwak @youn9k