Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#681) μ„€μ • 화면을 μΆ”κ°€ κ΅¬ν˜„ν•©λ‹ˆλ‹€. #707

Merged
merged 3 commits into from
Jun 30, 2024
Merged

πŸ”€ :: (#681) μ„€μ • 화면을 μΆ”κ°€ κ΅¬ν˜„ν•©λ‹ˆλ‹€. #707

merged 3 commits into from
Jun 30, 2024

Conversation

youn9k
Copy link
Member

@youn9k youn9k commented Jun 29, 2024

πŸ’‘ λ°°κ²½ 및 κ°œμš”

λ‘œκ·Έμ•„μ›ƒ κΈ°λŠ₯이 ν•„μš”ν–ˆμŠ΅λ‹ˆλ‹€.

Resolves: #681 #600

πŸ“ƒ μž‘μ—…λ‚΄μš©

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-29.at.21.38.43.mp4
  • λ‘œκ·Έμ•„μ›ƒ API μΆ”κ°€
  • λ‘œκ·Έμ•„μ›ƒ API 영ν–₯λ°›λŠ” κ³³λ“€ μ—λŸ¬ 핸듀링
  • λ‘œκ·Έμ•„μ›ƒ λ²„νŠΌ μΆ”κ°€
  • λΉ„λ‘œκ·ΈμΈ μ‹œ λ‘œκ·Έμ•„μ›ƒ & νšŒμ›νƒˆν‡΄ λ²„νŠΌ 숨기기
  • μ„€μ • ν™”λ©΄ λ²„νŠΌλ“€ TableView둜 λ¦¬νŒ©ν† λ§

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

  • μ—λŸ¬μ²˜λ¦¬κ°€ λΆ€μ‘±ν•œ 곳이 λ§Žμ„ν…λ° κ°μ•ˆν•˜κ³  λ΄μ£Όμ„Έμš©

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 29, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions github-actions bot added ✨ Feature 피쳐 개발 2️⃣ Priority: Medium μš°μ„ μˆœμœ„ 쀑 labels Jun 29, 2024
@github-actions GitHub Actions
Copy link

βœ… μ΄μŠˆμ™€ PR의 Labels 동기화λ₯Ό μ„±κ³΅ν–ˆμ–΄μš”!

@youn9k youn9k linked an issue Jun 29, 2024 that may be closed by this pull request
μ„€μ •ν™”λ©΄ νšŒμ›νƒˆν‡΄ λ ˆμ΄λΈ” λΉ„λ‘œκ·ΈμΈ μ‹œ νžˆλ“  처리 #600
Closed
@youn9k youn9k merged commit 7aba230 into develop Jun 30, 2024
3 checks passed
@youn9k youn9k deleted the 681-implement-setting branch June 30, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@baekteun baekteun Awaiting requested review from baekteun baekteun is a code owner

Assignees

@youn9k youn9k

Labels
2️⃣ Priority: Medium μš°μ„ μˆœμœ„ 쀑 ✨ Feature 피쳐 개발
Projects
None yet
Milestone
No milestone
3 participants
@youn9k @KangTaeHoon @yongbeomkwak