Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#670) ํ”„๋กœํ•„ ์ด๋ฏธ์ง€ ๋ถˆ๋Ÿฌ์˜ค๊ธฐ DTO ๋ณ€๊ฒฝ์‚ฌํ•ญ ๋ฐ˜์˜ #714

Merged
merged 3 commits into from
Jun 30, 2024
Merged

๐Ÿ”€ :: (#670) ํ”„๋กœํ•„ ์ด๋ฏธ์ง€ ๋ถˆ๋Ÿฌ์˜ค๊ธฐ DTO ๋ณ€๊ฒฝ์‚ฌํ•ญ ๋ฐ˜์˜ #714

merged 3 commits into from
Jun 30, 2024

Conversation

youn9k
Copy link
Member

@youn9k youn9k commented Jun 30, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

DTO๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

Resolves: #670

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

DTO์™€ Entity, ๊ธฐ์กด์— WMImageAPI๋กœ ์ด๋ฏธ์ง€๋ฅผ ๋ถˆ๋Ÿฌ์˜ค๋Š” ๋กœ์ง์„ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
๊ธฐ์กด DTO

type: String? // panchi
version: Int

๋ณ€๊ฒฝ๋œ DTO

type: String
name: String // panchi
url: String // ~~/panchi.png

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 30, 2024 •
edited
Loading

โœ… Successful finished SwiftLint

@github-actions github-actions bot added 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ ๐Ÿš€ API API ๋ณ€๊ฒฝ์‚ฌํ•ญ ๋Œ€์‘ labels Jun 30, 2024
@github-actions GitHub Actions
Copy link

โœ… ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@youn9k youn9k merged commit 4a1cb56 into develop Jun 30, 2024
3 checks passed
@youn9k youn9k deleted the 670-update-image-entity branch June 30, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@baekteun baekteun Awaiting requested review from baekteun baekteun is a code owner

Assignees

@youn9k youn9k

Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ ๐Ÿš€ API API ๋ณ€๊ฒฝ์‚ฌํ•ญ ๋Œ€์‘
Projects
None yet
Milestone
No milestone
3 participants
@youn9k @KangTaeHoon @yongbeomkwak