Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#715) ๊ณต์ง€์‚ฌํ•ญ ๋ฆฌ์ŠคํŠธ์— ์ฝ์—ˆ๋Š”์ง€ ์—ฌ๋ถ€ ์ธ๋””์ผ€์ดํ„ฐ ์ถ”๊ฐ€ #718

Merged
merged 6 commits into from
Jul 2, 2024

Conversation

youn9k
Copy link
Member

@youn9k youn9k commented Jun 30, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

Resolves: #715

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ๋นจ๊ฐ„ ์  ์ด๋ฏธ์ง€ ๋ฆฌ์†Œ์Šค๋ฅผ ์ถ”๊ฐ€ํ•˜๊ณ  NSMutableAttributedString + NSTextAttachment ์œผ๋กœ ๊ตฌํ˜„
  • ์…€ ์ œ๋ชฉ ๋ถ€๋ถ„ ์˜ค๋ฅธ์ชฝ ์—ฌ๋ฐฑ 20 -> 60์œผ๋กœ ์ˆ˜์ •
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-30.at.18.34.11.mp4

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

Copy link

github-actions bot commented Jun 30, 2024

โœ… Successful finished SwiftLint

@github-actions github-actions bot added โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ 2๏ธโƒฃ Priority: Medium ์šฐ์„ ์ˆœ์œ„ ์ค‘ labels Jun 30, 2024
Copy link

โœ… ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์„ฑ๊ณตํ–ˆ์–ด์š”!

youn9k added 2 commits June 30, 2024 20:22
์˜ค๋ฅธ์ชฝ ํŒจ๋”ฉ 20์œผ๋กœ ๋ณต๊ท€, ์…€ ์„ ํƒ ์‹œ ์œ ์ €๋””ํดํŠธ ์ €์žฅ X
@youn9k youn9k merged commit b96e43c into develop Jul 2, 2024
3 checks passed
@youn9k youn9k deleted the 715-indicator-notice-cell branch July 2, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2๏ธโƒฃ Priority: Medium ์šฐ์„ ์ˆœ์œ„ ์ค‘ โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ
Projects
None yet
3 participants