Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#663) ์œ ์ € ํ”„๋กœํ•„ DTO ๋ณ€๊ฒฝ์— ๋”ฐ๋ฅธ ๋Œ€์‘ #740

Merged
merged 3 commits into from
Jul 6, 2024
Merged

๐Ÿ”€ :: (#663) ์œ ์ € ํ”„๋กœํ•„ DTO ๋ณ€๊ฒฝ์— ๋”ฐ๋ฅธ ๋Œ€์‘ #740

merged 3 commits into from
Jul 6, 2024

Conversation

KangTaeHoon
Copy link
Contributor

@KangTaeHoon KangTaeHoon commented Jul 6, 2024 •
edited
Loading

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

์œ ์ € ํ”„๋กœํ•„ DTO ๋ณ€๊ฒฝ์— ๋”ฐ๋ฅธ ๋Œ€์‘

Resolves: #663

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • version ์ œ๊ฑฐ, itemCount ์ถ”๊ฐ€
  • ์—ฐ๊ด€ Entity, Preference ์ˆ˜์ •

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

  • createAt์€ ์‚ฌ์šฉ์ฒ˜๊ฐ€ ์—†์–ด์„œ ๋„ฃ์ง€ ์•Š์Œ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024 •
edited
Loading

โœ… Successful finished SwiftLint

@github-actions github-actions bot added 1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ ๐Ÿš€ API API ๋ณ€๊ฒฝ์‚ฌํ•ญ ๋Œ€์‘ labels Jul 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024

โœ… ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@KangTaeHoon KangTaeHoon merged commit b6a01b9 into develop Jul 6, 2024
3 checks passed
@KangTaeHoon KangTaeHoon deleted the 663-modified-dto-user-info branch July 6, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@baekteun baekteun baekteun approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@KangTaeHoon KangTaeHoon

Labels
1๏ธโƒฃ Priority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ ๐Ÿš€ API API ๋ณ€๊ฒฝ์‚ฌํ•ญ ๋Œ€์‘ โšก๏ธ Simple ๊ฐ„๋‹จํ•œ ๋ณ€๊ฒฝ์‚ฌํ•ญ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

์œ ์ € ํ”„๋กœํ•„ DTO์— ๋”ฐ๋ผ PreferenceManager.UserInfo ๋ณ€๊ฒฝ
3 participants
@KangTaeHoon @yongbeomkwak @baekteun