Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#757) ๊ฒ€์ƒ‰์—์„œ ์Šคํฌ๋กค ์˜ฌ๋ฆด ๋•Œ pinned Header ๊ฑธ์น˜๊ธฐ #760

Merged
merged 23 commits into from
Jul 11, 2024

Conversation

yongbeomkwak
Copy link
Member

@yongbeomkwak yongbeomkwak commented Jul 9, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๊ฒ€์ƒ‰ ๊ฒฐ๊ณผ๋ฅผ ํ™•์žฅํ•˜์—ฌ ๋ณด๊ธฐ ์œ„ํ•ด ๊ฒ€์ƒ‰ ๋ฐ”๋ฅผ ๋ถˆํ•„์š”ํ•  ๋•Œ ์œ„๋กœ ๋ฐ€์–ด๋ฒ„๋ฆฝ๋‹ˆ๋‹ค.

Resolves: #757 #650

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-10.at.16.58.37.mp4
  • searchGlobalScrollState์„ ๊ตฌํ˜„ํ•˜์—ฌ ํ™”๋ฉด์„ ๋›ฐ์–ด๋„˜์€ ์ด๋ฒคํŠธ ์ „๋‹ฌ์„ ์—ฐ๊ฒฐํ–ˆํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ํ•˜์œ„ ์Šคํฌ๋กค ์ •๋ณด๋ฅผ ์ƒ๋‹จ์— ์ „๋‹ฌํ•ฉ๋‹ˆ๋‹ค.
  • ํ•˜๋‹จ ํƒญ๋ฐ”์—์„œ ๊ฒ€์ƒ‰์„ ๋‘๋ฒˆ ํด๋ฆญ ์‹œ ํ˜„์žฌ ๊ฒ€์ƒ‰ํ™”๋ฉด์˜ ๊ฒฐ๊ณผ๋ฅผ ์ƒ๋‹จ์œผ๋กœ ๋Œ์–ด ์˜ฌ๋ฆฝ๋‹ˆ๋‹ค.

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

๊ตฌํ˜„ ์‹œ์— ๊ณ ๋ฏผ์ด์—ˆ๋˜ ์ ๋“ค ํ˜น์€ ํŠน์ • ๋ถ€๋ถ„์— ๋Œ€ํ•œ ์˜๋„๊ฐ€ ์žˆ์—ˆ๋‹ค๋ฉด PR ๋ฆฌ๋ทฐ์˜ ์ดํ•ด๋ฅผ ๋•๊ธฐ ์œ„ํ•ด ์„œ์ˆ ํ•ด์ฃผ์„ธ์š”!

๋˜ํ•œ ๋ฆฌ๋ทฐ์–ด์—๊ฒŒ ํŠน์ • ๋ถ€๋ถ„์— ๋Œ€ํ•œ ์ง‘์ค‘ ํ˜น์€ ์ฝ”๋ฉ˜ํŠธ ํ˜น์€ ์งˆ๋ฌธ์„ ์š”์ฒญํ•˜๋Š” ๊ฒฝ์šฐ์— ์ž‘์„ฑํ•˜๋ฉด ์ข‹์•„์š”!

e.g. ์ž‘์—…์„ ๋๋‚ด์•ผํ•  ์‹œ๊ฐ„์ด ์–ผ๋งˆ ์—†์–ด ํ™•์žฅ์„ฑ๋ณด๋‹ค๋Š” ๋™์ž‘์„ ์œ„์ฃผ๋กœ ๋งŒ๋“ค์—ˆ์–ด์š”! ๊ฐ์•ˆํ•˜๊ณ  ๋ฆฌ๋ทฐํ•ด์ฃผ์„ธ์š”!

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

Copy link

github-actions bot commented Jul 9, 2024

โœ… Successful finished SwiftLint

Copy link

github-actions bot commented Jul 9, 2024

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@yongbeomkwak

Base automatically changed from 755-connect-song-cart-on-search-result to develop July 9, 2024 07:37
@yongbeomkwak yongbeomkwak changed the title ๐Ÿ”€ :: (#777) ๊ฒ€์ƒ‰์—์„œ ์Šคํฌ๋กค ์˜ฌ๋ฆด ๋•Œ pinned Header ๊ฑธ์น˜๊ธฐ ๐Ÿ”€ :: (#757) ๊ฒ€์ƒ‰์—์„œ ์Šคํฌ๋กค ์˜ฌ๋ฆด ๋•Œ pinned Header ๊ฑธ์น˜๊ธฐ Jul 11, 2024
@yongbeomkwak yongbeomkwak merged commit e344ec4 into develop Jul 11, 2024
3 checks passed
@yongbeomkwak yongbeomkwak deleted the 757-implement-fix-pinned-header branch July 11, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants