Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#762) 검색 νƒ­ λ””μžμΈ κ²€μˆ˜ μ™„λ£Œ #763

Merged
merged 10 commits into from
Jul 11, 2024
Merged

πŸ”€ :: (#762) 검색 νƒ­ λ””μžμΈ κ²€μˆ˜ μ™„λ£Œ #763

merged 10 commits into from
Jul 11, 2024

Conversation

yongbeomkwak
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

검색화면 λ””μžμΈ κ²€μˆ˜λ₯Ό μ§„ν–‰ν–ˆμŠ΅λ‹ˆλ‹€.

Resolves: #762

πŸ“ƒ μž‘μ—…λ‚΄μš©

κ°„λ‹¨ν•œ λ ˆμ΄μ•„μ›ƒ 간격 μ‘°μ ˆμ •λ„ μžˆμŠ΅λ‹ˆλ‹€.

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

κ΅¬ν˜„ μ‹œμ— κ³ λ―Όμ΄μ—ˆλ˜ 점듀 ν˜Ήμ€ νŠΉμ • 뢀뢄에 λŒ€ν•œ μ˜λ„κ°€ μžˆμ—ˆλ‹€λ©΄ PR 리뷰의 이해λ₯Ό 돕기 μœ„ν•΄ μ„œμˆ ν•΄μ£Όμ„Έμš”!

λ˜ν•œ λ¦¬λ·°μ–΄μ—κ²Œ νŠΉμ • 뢀뢄에 λŒ€ν•œ 집쀑 ν˜Ήμ€ μ½”λ©˜νŠΈ ν˜Ήμ€ μ§ˆλ¬Έμ„ μš”μ²­ν•˜λŠ” κ²½μš°μ— μž‘μ„±ν•˜λ©΄ μ’‹μ•„μš”!

e.g. μž‘μ—…μ„ 끝내야할 μ‹œκ°„μ΄ μ–Όλ§ˆ μ—†μ–΄ ν™•μž₯μ„±λ³΄λ‹€λŠ” λ™μž‘μ„ μœ„μ£Όλ‘œ λ§Œλ“€μ—ˆμ–΄μš”! κ°μ•ˆν•˜κ³  λ¦¬λ·°ν•΄μ£Όμ„Έμš”!

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions github-actions bot added 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ ⚑️ Simple κ°„λ‹¨ν•œ 변경사항 labels Jul 10, 2024
@github-actions GitHub Actions
Copy link

βœ… μ΄μŠˆμ™€ PR의 Labels 동기화λ₯Ό μ„±κ³΅ν–ˆμ–΄μš”!

Base automatically changed from 757-implement-fix-pinned-header to develop July 11, 2024 14:36
@yongbeomkwak yongbeomkwak merged commit 835c4b6 into develop Jul 11, 2024
2 checks passed
@yongbeomkwak yongbeomkwak deleted the 762-fix-search-result-layout-mistake branch July 11, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youn9k youn9k youn9k approved these changes

@baekteun baekteun baekteun approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@KangTaeHoon KangTaeHoon Awaiting requested review from KangTaeHoon KangTaeHoon is a code owner

Assignees

@yongbeomkwak yongbeomkwak

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ ⚑️ Simple κ°„λ‹¨ν•œ 변경사항
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

검색 κ²°κ³Όν™”λ©΄ λ””μžμΈ κ²€μˆ˜
3 participants
@yongbeomkwak @youn9k @baekteun