Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#769) μ’‹μ•„μš” 탭을 κ΅¬ν˜„ν•©λ‹ˆλ‹€. #774

Merged
merged 7 commits into from
Jul 13, 2024
Merged

πŸ”€ :: (#769) μ’‹μ•„μš” 탭을 κ΅¬ν˜„ν•©λ‹ˆλ‹€. #774

merged 7 commits into from
Jul 13, 2024

Conversation

youn9k
Copy link
Member

@youn9k youn9k commented Jul 12, 2024

πŸ’‘ λ°°κ²½ 및 κ°œμš”

μ’‹μ•„μš” 탭을 κ΅¬ν˜„ν•©λ‹ˆλ‹€
#769

πŸ“ƒ μž‘μ—…λ‚΄μš©

남은 μž‘μ—…

  • μœ μ €λ„λ©”μΈ api 리슀폰슀 λ³€κ²½ λŒ€μ‘
  • λ·°λͺ¨λΈ λ“± λ ˆκ±°μ‹œ μ½”λ“œ 제거
  • μŠ€ν† λ¦¬λ³΄λ“œ 제거

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

μŠ€ν† λ¦¬λ³΄λ“œμ—μ„œ μ½”λ“œλ² μ΄μŠ€λ‘œ λ¦¬νŒ©ν† λ§ν–ˆμŠ΅λ‹ˆλ‹€.

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@youn9k youn9k self-assigned this Jul 12, 2024
@github-actions github-actions bot added 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ ✨ Feature 피쳐 개발 labels Jul 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

βœ… μ΄μŠˆμ™€ PR의 Labels 동기화λ₯Ό μ„±κ³΅ν–ˆμ–΄μš”!

Base automatically changed from 722-implement-storage-feature to develop July 12, 2024 15:44
@youn9k youn9k merged commit 444205b into develop Jul 13, 2024
3 checks passed
@youn9k youn9k deleted the 769-implement-like-tab branch July 13, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@baekteun baekteun Awaiting requested review from baekteun baekteun is a code owner

Assignees

@youn9k youn9k

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ κΈ΄κΈ‰ ✨ Feature 피쳐 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youn9k @KangTaeHoon @yongbeomkwak