Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#780) λ…Έλž˜λ°© λ°”ν…€ μ‹œνŠΈ #786

Merged
merged 15 commits into from
Jul 17, 2024
Merged

πŸ”€ :: (#780) λ…Έλž˜λ°© λ°”ν…€ μ‹œνŠΈ #786

merged 15 commits into from
Jul 17, 2024

Conversation

yongbeomkwak
Copy link
Member

@yongbeomkwak yongbeomkwak commented Jul 15, 2024 •
edited
Loading

πŸ’‘ λ°°κ²½ 및 κ°œμš”

μŒμ•… 상세 화면에 ν•„μš”ν•œ λ…Έλž˜λ°© λ°”ν…€μ‹œνŠΈ κ°œλ°œμ„ μ§„ν–‰ν•©λ‹ˆλ‹€.

Resolves: #780

πŸ“ƒ μž‘μ—…λ‚΄μš©

Simulator.Screen.Recording.-.Default.-.2024-07-15.at.10.48.01.mp4
  • Karaoke VC
  • infoView
  • ContentView 개발
  • Demo ν…ŒμŠ€νŠΈ

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

μ‚¬μš© μ‹œ

  1. KaraokeFactoryλ₯Ό μ£Όμž…ν•©λ‹ˆλ‹€.
  2. swiftmakeViewContoller(tj: Int? ky: Int?) ν•¨μˆ˜μ— ν•΄λ‹Ή λ…Έλž˜λ°© 정보λ₯Ό λ„£μ–΄μ€λ‹ˆλ‹€.
  3. showBottomSheetλ₯Ό λ‹€μŒκ³Ό 같이 λ„£μ–΄μ€λ‹ˆλ‹€.
 self.showBottomSheet(content: vc, size: .fixed(268 + SAFEAREA_BOTTOM_HEIGHT()))

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions github-actions bot added 1️⃣ Priority: High μš°μ„ μˆœμœ„ 상 ✨ Feature 피쳐 개발 labels Jul 15, 2024
@github-actions GitHub Actions
Copy link

βœ… μ΄μŠˆμ™€ PR의 Labels 동기화λ₯Ό μ„±κ³΅ν–ˆμ–΄μš”!

@yongbeomkwak yongbeomkwak merged commit ab688a2 into develop Jul 17, 2024
3 checks passed
@yongbeomkwak yongbeomkwak deleted the 780-karaoke-bottom-sheet branch July 17, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@youn9k youn9k youn9k approved these changes

@baekteun baekteun baekteun approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

Assignees

@yongbeomkwak yongbeomkwak

Labels
1️⃣ Priority: High μš°μ„ μˆœμœ„ 상 ✨ Feature 피쳐 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

λ…Έλž˜λ°© λ°”ν…€μ‹œνŠΈ λ§Œλ“€κΈ°
4 participants
@yongbeomkwak @KangTaeHoon @youn9k @baekteun