Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#887) ์•ฑ ์ ‘์† ์‹œ ์œ ์ € ์ •๋ณด ์…‹ํŒ… #888

Merged
merged 2 commits into from
Jul 28, 2024

Conversation

KangTaeHoon
Copy link
Contributor

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

  • ์•ฑ ์ ‘์† ์‹œ ์œ ์ € ์ •๋ณด ์…‹ํŒ…

Resolves: #887

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • Intro(์Šคํ”Œ๋ž˜์‰ฌ) ๋ทฐ๋ชจ๋ธ์—์„œ ์œ ์ € ๋กœ๊ทธ์ธ ํ† ํฐ ๋งŒ๋ฃŒ ์ฒดํฌ ๋•Œ๋ฌธ์— ์œ ์ € ์ •๋ณด๋ฅผ ์š”์ฒญํ•˜๊ณ  ์žˆ์–ด ๊ทธ ์š”์ฒญ์— ๋ผ์›Œ ๋„ฃ์Œ.

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

x

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

Copy link

github-actions bot commented Jul 28, 2024

โœ… Successful finished SwiftLint

Copy link

โœ… ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@github-actions github-actions bot added the 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ label Jul 28, 2024
@KangTaeHoon KangTaeHoon merged commit 560707d into develop Jul 28, 2024
5 checks passed
@KangTaeHoon KangTaeHoon deleted the 887-set-user-info-when-app-launch branch July 28, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰
Projects
None yet
Development

Successfully merging this pull request may close these issues.

์•ฑ ์ ‘์† ์‹œ ์œ ์ € ์ •๋ณด ์…‹ํŒ…
3 participants