Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#848) ๋‹‰๋„ค์ž„ ๋ณ€๊ฒฝ ๋ฐ ์—ด๋งค ๋ฝ‘๊ธฐ ๋ฐ˜์‘ ๊ตฌํ˜„ #898

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

youn9k
Copy link
Member

@youn9k youn9k commented Jul 28, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๋‚จ์€ ์ž‘์—…์„ ํ›„๋”ฑํ›„๋”ฑ ์ฒ˜๋ฆฌ์ค‘์ด์—์š”๐Ÿงน

Resolves: #848

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ๋‹‰๋„ค์ž„ ๋ณ€๊ฒฝ ๊ธฐ๋Šฅ ๊ตฌํ˜„
  • ์—ด๋งค ๊ฐฏ์ˆ˜ ํ‘œ๊ธฐ
  • ์—ด๋งค ๋ฝ‘๊ธฐ ์‹œ ์œ ์ €์ •๋ณด ๋ฆฌํ”„๋ ˆ์‰ฌ

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

Copy link

github-actions bot commented Jul 28, 2024

โœ… Successful finished SwiftLint

@github-actions github-actions bot added 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ labels Jul 28, 2024
Copy link

โœ… ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@KangTaeHoon
Copy link
Contributor

KangTaeHoon commented Jul 28, 2024

์ตœ์ดˆ์— PreferenceManager.$userInfo ๊ฐ’์„ ๋ฐ›์•„์˜จ ์ดํ›„์—๋Š” ๋‹‰๋„ค์ž„์ด๋‚˜ ํ”„๋กœํ•„์ด ๋ณ€๊ฒฝ๋˜์–ด๋„ ๋ฆฌ์—‘ํ„ฐ์˜ state ๊ฐ’๋งŒ ๋ณ€๊ฒฝํ•ด์„œ ๋ทฐ์— ๋ฐ˜์˜ํ•ด์ฃผ๊ณ  PreferenceManager.$userInfo ๊ฐ’์€ ๋ณ€๊ฒฝํ•˜์ง€ ์•Š๋Š”๊ฑธ๋กœ ๋ณด์ด๋Š”๋ฐ์š”. ๋งž๋‚˜์š”?

@youn9k
Copy link
Member Author

youn9k commented Jul 29, 2024

์ตœ์ดˆ์— PreferenceManager.$userInfo ๊ฐ’์„ ๋ฐ›์•„์˜จ ์ดํ›„์—๋Š” ๋‹‰๋„ค์ž„์ด๋‚˜ ํ”„๋กœํ•„์ด ๋ณ€๊ฒฝ๋˜์–ด๋„ ๋ฆฌ์—‘ํ„ฐ์˜ state ๊ฐ’๋งŒ ๋ณ€๊ฒฝํ•ด์„œ ๋ทฐ์— ๋ฐ˜์˜ํ•ด์ฃผ๊ณ  PreferenceManager.$userInfo ๊ฐ’์€ ๋ณ€๊ฒฝํ•˜์ง€ ์•Š๋Š”๊ฑธ๋กœ ๋ณด์ด๋Š”๋ฐ์š”. ๋งž๋‚˜์š”?

์–ด์ œ ๊ฒฐ์ •ํ–ˆ๋˜๋Œ€๋กœ ๋‹‰๋„ค์ž„ ๋ณ€๊ฒฝ ์‹œ์—๋Š” ์„œ๋ฒ„๋กœ๋ถ€ํ„ฐ userInfo๋ฅผ ๋ถˆ๋Ÿฌ์™€์„œ PreferenceManager.setUserInfo๋ฅผ ํ˜ธ์ถœ ์ค‘์ž…๋‹ˆ๋‹ค.
๊ทผ๋ฐ ํ”„๋กœํ•„์ด๋ฏธ์ง€ ๋ณ€๊ฒฝ ๊ธฐ๋Šฅ ์ž์ฒด๊ฐ€ ๊ตฌํ˜„์ด ์•ˆ๋˜์–ด์žˆ๋„ค์š”๐Ÿ˜‚ ํ•ด๋‹น PR์—์„œ ์ถ”๊ฐ€ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!

@KangTaeHoon
Copy link
Contributor

์ตœ์ดˆ์— PreferenceManager.$userInfo ๊ฐ’์„ ๋ฐ›์•„์˜จ ์ดํ›„์—๋Š” ๋‹‰๋„ค์ž„์ด๋‚˜ ํ”„๋กœํ•„์ด ๋ณ€๊ฒฝ๋˜์–ด๋„ ๋ฆฌ์—‘ํ„ฐ์˜ state ๊ฐ’๋งŒ ๋ณ€๊ฒฝํ•ด์„œ ๋ทฐ์— ๋ฐ˜์˜ํ•ด์ฃผ๊ณ  PreferenceManager.$userInfo ๊ฐ’์€ ๋ณ€๊ฒฝํ•˜์ง€ ์•Š๋Š”๊ฑธ๋กœ ๋ณด์ด๋Š”๋ฐ์š”. ๋งž๋‚˜์š”?

์–ด์ œ ๊ฒฐ์ •ํ–ˆ๋˜๋Œ€๋กœ ๋‹‰๋„ค์ž„ ๋ณ€๊ฒฝ ์‹œ์—๋Š” ์„œ๋ฒ„๋กœ๋ถ€ํ„ฐ userInfo๋ฅผ ๋ถˆ๋Ÿฌ์™€์„œ PreferenceManager.setUserInfo๋ฅผ ํ˜ธ์ถœ ์ค‘์ž…๋‹ˆ๋‹ค.

๊ทผ๋ฐ ํ”„๋กœํ•„์ด๋ฏธ์ง€ ๋ณ€๊ฒฝ ๊ธฐ๋Šฅ ์ž์ฒด๊ฐ€ ๊ตฌํ˜„์ด ์•ˆ๋˜์–ด์žˆ๋„ค์š”๐Ÿ˜‚ ํ•ด๋‹น PR์—์„œ ์ถ”๊ฐ€ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!

๋‹‰๋ณ€์ด ์•„๋‹ˆ๋ผ ์—ด๋งค๋ฝ‘๊ธฐ ์•„๋‹Œ๊ฐ€์š”?

@youn9k
Copy link
Member Author

youn9k commented Jul 29, 2024

์ตœ์ดˆ์— PreferenceManager.$userInfo ๊ฐ’์„ ๋ฐ›์•„์˜จ ์ดํ›„์—๋Š” ๋‹‰๋„ค์ž„์ด๋‚˜ ํ”„๋กœํ•„์ด ๋ณ€๊ฒฝ๋˜์–ด๋„ ๋ฆฌ์—‘ํ„ฐ์˜ state ๊ฐ’๋งŒ ๋ณ€๊ฒฝํ•ด์„œ ๋ทฐ์— ๋ฐ˜์˜ํ•ด์ฃผ๊ณ  PreferenceManager.$userInfo ๊ฐ’์€ ๋ณ€๊ฒฝํ•˜์ง€ ์•Š๋Š”๊ฑธ๋กœ ๋ณด์ด๋Š”๋ฐ์š”. ๋งž๋‚˜์š”?

์–ด์ œ ๊ฒฐ์ •ํ–ˆ๋˜๋Œ€๋กœ ๋‹‰๋„ค์ž„ ๋ณ€๊ฒฝ ์‹œ์—๋Š” ์„œ๋ฒ„๋กœ๋ถ€ํ„ฐ userInfo๋ฅผ ๋ถˆ๋Ÿฌ์™€์„œ PreferenceManager.setUserInfo๋ฅผ ํ˜ธ์ถœ ์ค‘์ž…๋‹ˆ๋‹ค.
๊ทผ๋ฐ ํ”„๋กœํ•„์ด๋ฏธ์ง€ ๋ณ€๊ฒฝ ๊ธฐ๋Šฅ ์ž์ฒด๊ฐ€ ๊ตฌํ˜„์ด ์•ˆ๋˜์–ด์žˆ๋„ค์š”๐Ÿ˜‚ ํ•ด๋‹น PR์—์„œ ์ถ”๊ฐ€ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!

๋‹‰๋ณ€์ด ์•„๋‹ˆ๋ผ ์—ด๋งค๋ฝ‘๊ธฐ ์•„๋‹Œ๊ฐ€์š”?

์—ฅ ๊ทธ๋Ÿฌ๋„ค์š” ์ „ ๋ญ˜ํ•œ๊ฑธ๊นŒ์š”

@KangTaeHoon
Copy link
Contributor

์ตœ์ดˆ์— PreferenceManager.$userInfo ๊ฐ’์„ ๋ฐ›์•„์˜จ ์ดํ›„์—๋Š” ๋‹‰๋„ค์ž„์ด๋‚˜ ํ”„๋กœํ•„์ด ๋ณ€๊ฒฝ๋˜์–ด๋„ ๋ฆฌ์—‘ํ„ฐ์˜ state ๊ฐ’๋งŒ ๋ณ€๊ฒฝํ•ด์„œ ๋ทฐ์— ๋ฐ˜์˜ํ•ด์ฃผ๊ณ  PreferenceManager.$userInfo ๊ฐ’์€ ๋ณ€๊ฒฝํ•˜์ง€ ์•Š๋Š”๊ฑธ๋กœ ๋ณด์ด๋Š”๋ฐ์š”. ๋งž๋‚˜์š”?

์–ด์ œ ๊ฒฐ์ •ํ–ˆ๋˜๋Œ€๋กœ ๋‹‰๋„ค์ž„ ๋ณ€๊ฒฝ ์‹œ์—๋Š” ์„œ๋ฒ„๋กœ๋ถ€ํ„ฐ userInfo๋ฅผ ๋ถˆ๋Ÿฌ์™€์„œ PreferenceManager.setUserInfo๋ฅผ ํ˜ธ์ถœ ์ค‘์ž…๋‹ˆ๋‹ค.
๊ทผ๋ฐ ํ”„๋กœํ•„์ด๋ฏธ์ง€ ๋ณ€๊ฒฝ ๊ธฐ๋Šฅ ์ž์ฒด๊ฐ€ ๊ตฌํ˜„์ด ์•ˆ๋˜์–ด์žˆ๋„ค์š”๐Ÿ˜‚ ํ•ด๋‹น PR์—์„œ ์ถ”๊ฐ€ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!

๋‹‰๋ณ€์ด ์•„๋‹ˆ๋ผ ์—ด๋งค๋ฝ‘๊ธฐ ์•„๋‹Œ๊ฐ€์š”?

์—ฅ ๊ทธ๋Ÿฌ๋„ค์š” ์ „ ๋ญ˜ํ•œ๊ฑธ๊นŒ์š”

์š”์ง€๋Š” PreferenceManager.userInfo์˜ ๋ณ€๊ฒฝ์—†์ด ๋ฆฌ์—‘ํ„ฐ ์Šคํ…Œ์ด์—ํŠธ์— ์˜์กดํ•ด์„œ UI๋ฅผ ๋ณ€๊ฒฝํ•˜๊ณ ์žˆ๋Š”๋ฐ, ๊ทธ๋Ÿฌ๋ฉด ์•ฑ์„ ๊ป๋‹ค๊ฐ€ ์ผœ๋ฉด ๋ฐ˜์˜์ด ๋˜๋ƒ๋Š”๊ฑฐ์—์š”.

@KangTaeHoon
Copy link
Contributor

๋‚ด ์ •๋ณด๊ฐ€ ๋ณ€๊ฒฝ๋˜๋Š” ๊ฒฝ์šฐ (์—ด๋งค ์ถ”๊ฐ€/์†Œ์ง„, ๋‹‰๋„ค์ž„, ํ”„์‚ฌ๋ณ€๊ฒฝ ๋“ฑ)์—๋Š” ๋ชจ๋‘ ์„œ๋ฒ„์˜ userInfo api ๋‹น๊ฒจ์™€์„œ ๋ฐ˜์˜ํ•ด์ฃผ๊ณ , ๋กœ์ปฌ ๋””๋น„๋กœ ํ™œ์šฉํ•˜๋Š” ํ”„๋ฆฌํผ๋Ÿฐ์Šค์—๋„ ๋™๊ธฐํ™”๋ฅผ ์‹œ์ผœ์ฃผ๋Š”๊ฒŒ ๋งž๋‹ค๊ณ  ์ƒ๊ฐํ•ด์š”.

@youn9k
Copy link
Member Author

youn9k commented Jul 29, 2024

๋‚ด ์ •๋ณด๊ฐ€ ๋ณ€๊ฒฝ๋˜๋Š” ๊ฒฝ์šฐ (์—ด๋งค ์ถ”๊ฐ€/์†Œ์ง„, ๋‹‰๋„ค์ž„, ํ”„์‚ฌ๋ณ€๊ฒฝ ๋“ฑ)์—๋Š” ๋ชจ๋‘ ์„œ๋ฒ„์˜ userInfo api ๋‹น๊ฒจ์™€์„œ ๋ฐ˜์˜ํ•ด์ฃผ๊ณ , ๋กœ์ปฌ ๋””๋น„๋กœ ํ™œ์šฉํ•˜๋Š” ํ”„๋ฆฌํผ๋Ÿฐ์Šค์—๋„ ๋™๊ธฐํ™”๋ฅผ ์‹œ์ผœ์ฃผ๋Š”๊ฒŒ ๋งž๋‹ค๊ณ  ์ƒ๊ฐํ•ด์š”.

๊ทธ์ตธ ์ˆ˜์ •ํ•ด๋‘˜๊ฒŒ์š”!

@KangTaeHoon KangTaeHoon merged commit db0c4c1 into develop Aug 1, 2024
3 checks passed
@KangTaeHoon KangTaeHoon deleted the 848-feature-change-nickname branch August 1, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๋‹‰๋„ค์ž„ ๋ณ€๊ฒฝ ๊ธฐ๋Šฅ ๊ตฌํ˜„
4 participants