🔀 :: (#812) Music Detail Feature 디렉토리 정리 #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baekteun
requested review from
yongbeomkwak,
kimdaehee0824,
KangTaeHoon and
youn9k
as code owners
✅ Successful finished SwiftLint |
✅ 이슈와 PR의 Labels 동기화를 성공했어요! |
KangTaeHoon
approved these changes
Jul 29, 2024
baekteun
force-pushed
the
812-credit-worker-song-list
branch
2 times, most recently
from
49acc72 to
3ca284a
Compare
baekteun
force-pushed
the
812-credit-worker-song-list
branch
from
3ca284a to
425e32e
Compare
yongbeomkwak
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 배경 및 개요
MusicDetailFeature의 디렉토리를 정리했어요.
📃 작업내용
기능 기반으로 디렉토리 구조에서 도메인 기반으로 디렉토리 구조를 변경했어요
기능 기반:
ViewControllers
- MusicDetailViewController.swift
- KaraokeViewController.swift
Views
- MusicDetailView.swift
- MusicControlView.swift
- KaraokeNumberView.swift
도메인 기반:
MusicDetail
- MusicDetailViewController.swift
- Views
- MusicDetailView.swift
- MusicControlView.swift
Karaoke
- KaraokeNumberViewController.swift
- Views
- KaraokeNumberView.swift
✅ PR 체크리스트
XCConfig,노션,README)"API 개발 완료됐어요","XCConfig 값 추가되었어요")