Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#812) CreditDomain κ΅¬ν˜„ #907

Merged
merged 1 commit into from
Jul 30, 2024
Merged

πŸ”€ :: (#812) CreditDomain κ΅¬ν˜„ #907

merged 1 commit into from
Jul 30, 2024

Conversation

baekteun
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

CreditDomain을 κ΅¬ν˜„ν–ˆμ–΄μš”

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • FetchCreditSongList API μ—°κ²°
  • Credit κ΄€λ ¨ ν•„μš” 객체 DI Regist

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions github-actions bot added the 1️⃣ Priority: High μš°μ„ μˆœμœ„ 상 label Jul 29, 2024
@github-actions GitHub Actions
Copy link

βœ… μ΄μŠˆμ™€ PR의 Labels 동기화λ₯Ό μ„±κ³΅ν–ˆμ–΄μš”!

@baekteun baekteun force-pushed the 812-credit-worker-song-list branch from cf9511b to 49acc72 Compare July 29, 2024 13:46
@baekteun baekteun force-pushed the 812-credit-domain branch 3 times, most recently from 37fad4d to ba3b996 Compare July 29, 2024 14:16
@baekteun baekteun force-pushed the 812-credit-worker-song-list branch from 49acc72 to 3ca284a Compare July 29, 2024 14:38
@baekteun baekteun force-pushed the 812-credit-domain branch 2 times, most recently from 83eb970 to 27b1aac Compare July 29, 2024 14:54
@baekteun baekteun force-pushed the 812-credit-worker-song-list branch from 3ca284a to 425e32e Compare July 29, 2024 17:16
@baekteun baekteun force-pushed the 812-credit-domain branch from 27b1aac to 9063623 Compare July 29, 2024 17:17
@baekteun baekteun force-pushed the 812-credit-domain branch from 9063623 to 44d7158 Compare July 29, 2024 17:18
Base automatically changed from 812-credit-worker-song-list to develop July 30, 2024 00:55
@baekteun baekteun merged commit 02c6c66 into develop Jul 30, 2024
3 checks passed
@baekteun baekteun deleted the 812-credit-domain branch July 30, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@baekteun baekteun

Labels
1️⃣ Priority: High μš°μ„ μˆœμœ„ 상
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baekteun @KangTaeHoon @yongbeomkwak