Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#899) μŒμ•… 상세 νŽ˜μ΄μ§€ μŒμ•… 제λͺ©, μ•„ν‹°μŠ€νŠΈ WMLabel -> WMFlowLabel μ „ν™˜ #931

Merged
merged 1 commit into from
Aug 1, 2024
Merged

πŸ”€ :: (#899) μŒμ•… 상세 νŽ˜μ΄μ§€ μŒμ•… 제λͺ©, μ•„ν‹°μŠ€νŠΈ WMLabel -> WMFlowLabel μ „ν™˜ #931

merged 1 commit into from
Aug 1, 2024

Conversation

baekteun
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

μŒμ•… 제λͺ© ν˜Ήμ€ μ•„ν‹°μŠ€νŠΈ(이건 μ‹€μ œλ‘œ κ·ΈλŸ°μ§€ μΌ€μ΄μŠ€ 확인 μ—†μŒ) λ¬Έμžμ—΄μ΄ κΈΈμ–΄μ„œ ν…μŠ€νŠΈκ°€ μ§€λ¦¬λŠ” ν˜„μƒμ΄ μžˆμ—ˆμ–΄μš”
μŒμ•… 상세 νŽ˜μ΄μ§€ μŒμ•… 제λͺ©, μ•„ν‹°μŠ€νŠΈ WMLabel -> WMFlowLabel μ „ν™˜

Resolves: #899

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • μŒμ•… 상세 νŽ˜μ΄μ§€ μŒμ•… 제λͺ©, μ•„ν‹°μŠ€νŠΈ WMLabel -> WMFlowLabel μ „ν™˜

βœ… PR 체크리슀트

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

@baekteun baekteun linked an issue Jul 31, 2024 that may be closed by this pull request
μŒμ•… 상세 νŽ˜μ΄μ§€: λ…Έλž˜ 제λͺ© 흐λ₯΄λŠ” Label둜 λ³€κ²½ #899
Closed
@github-actions github-actions bot added the ⚑️ Simple κ°„λ‹¨ν•œ 변경사항 label Jul 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

βœ… μ΄μŠˆμ™€ PR의 Labels 동기화λ₯Ό μ„±κ³΅ν–ˆμ–΄μš”!

@github-actions github-actions bot added the 2️⃣ Priority: Medium μš°μ„ μˆœμœ„ 쀑 label Jul 31, 2024
@KangTaeHoon
Copy link
Contributor

μ•„ν‹°μŠ€νŠΈκ°€ κΈ΄ μΌ€μ΄μŠ€λŠ” 이거? 제 폰은 μ•ˆκ·ΈλŸ¬λŠ”λ° 375기기둜 κ°€λ©΄ 흐λ₯΄λŠ” λ ˆμ΄λΈ” μ μš©λ λ“―

image

@baekteun baekteun merged commit 0d6c31a into develop Aug 1, 2024
5 checks passed
@baekteun baekteun deleted the 899-music-detail-flow-label branch August 1, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@baekteun baekteun

Labels
2️⃣ Priority: Medium μš°μ„ μˆœμœ„ 쀑 ⚑️ Simple κ°„λ‹¨ν•œ 변경사항
Projects
None yet
Milestone
No milestone
3 participants
@baekteun @KangTaeHoon @yongbeomkwak