Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#949, #791) ํ”„๋กœํ•„ ๋ณ€๊ฒฝ ๊ธฐ๋Šฅ ๊ตฌํ˜„ ์™ธ1 #952

Merged
merged 14 commits into from
Aug 2, 2024
Merged

๐Ÿ”€ :: (#949, #791) ํ”„๋กœํ•„ ๋ณ€๊ฒฝ ๊ธฐ๋Šฅ ๊ตฌํ˜„ ์™ธ1 #952

merged 14 commits into from
Aug 2, 2024

Conversation

KangTaeHoon
Copy link
Contributor

@KangTaeHoon KangTaeHoon commented Aug 1, 2024 •
edited
Loading

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

  • ํ”„๋กœํ•„ ๋ณ€๊ฒฝ ๊ธฐ๋Šฅ ๊ตฌํ˜„

Resolves: #949
Resolves: #791

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ํ”„๋กœํ•„ ๋ณ€๊ฒฝ ๊ธฐ๋Šฅ ๊ตฌํ˜„
  • ProfilePopupViewModel ๋ฆฌํŒฉํ† ๋ง
  • ๋„ค์ด๋ฐ ํ†ต์ผ(Popup)
  • ๊ณต์ง€์ƒ์„ธ > ๋ฌดํ•œ๋กœ๋”ฉ ํ˜„์ƒ ํ•ด๊ฒฐ
  • ๋ชจ๋‹ฌ ํ™”๋ฉด์˜ X๋ฒ„ํŠผ ์ขŒ์ธก์œผ๋กœ ์ด๋™

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024 •
edited
Loading

โœ… Successful finished SwiftLint

@github-actions github-actions bot added 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ labels Aug 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

โœ… ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@KangTaeHoon KangTaeHoon changed the title ๐Ÿ”€ :: (#949) ํ”„๋กœํ•„ ๋ณ€๊ฒฝ ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๐Ÿ”€ :: (#949, 791) ํ”„๋กœํ•„ ๋ณ€๊ฒฝ ๊ธฐ๋Šฅ ๊ตฌํ˜„ Aug 1, 2024
@KangTaeHoon KangTaeHoon changed the title ๐Ÿ”€ :: (#949, 791) ํ”„๋กœํ•„ ๋ณ€๊ฒฝ ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๐Ÿ”€ :: (#949, #791) ํ”„๋กœํ•„ ๋ณ€๊ฒฝ ๊ธฐ๋Šฅ ๊ตฌํ˜„ Aug 1, 2024
@KangTaeHoon KangTaeHoon changed the title ๐Ÿ”€ :: (#949, #791) ํ”„๋กœํ•„ ๋ณ€๊ฒฝ ๊ธฐ๋Šฅ ๊ตฌํ˜„ ๐Ÿ”€ :: (#949, #791) ํ”„๋กœํ•„ ๋ณ€๊ฒฝ ๊ธฐ๋Šฅ ๊ตฌํ˜„ ์™ธ1 Aug 1, 2024
@KangTaeHoon KangTaeHoon merged commit 72c19d9 into develop Aug 2, 2024
3 checks passed
@KangTaeHoon KangTaeHoon deleted the 949-set-profile-in-my-info branch August 2, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@youn9k youn9k youn9k approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@baekteun baekteun Awaiting requested review from baekteun baekteun is a code owner

Assignees

@KangTaeHoon KangTaeHoon

Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ
Projects
None yet
Milestone
No milestone
3 participants
@KangTaeHoon @yongbeomkwak @youn9k