Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#954, #955) ๋ถˆํ•„์š” ๋กœ์ง ์ œ๊ฑฐ #956

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

KangTaeHoon
Copy link
Contributor

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

  • ํ† ํฐ ๋งŒ๋ฃŒ ๋กœ์ง ์ œ๊ฑฐ

Resolves: #954
Resolves: #955

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ํ† ํฐ ๋งŒ๋ฃŒ ๋กœ์ง ์ œ๊ฑฐ
  • ๊ธฐํƒ€ ์ ‘๊ทผ ์ง€์ •์ž ์ˆ˜์ •

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

x

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

Copy link

github-actions bot commented Aug 2, 2024

โœ… Successful finished SwiftLint

Copy link

github-actions bot commented Aug 2, 2024

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@KangTaeHoon

@KangTaeHoon KangTaeHoon changed the title ๐Ÿ”€ :: [#954] ๋ถˆํ•„์š” ๋กœ์ง ์ œ๊ฑฐ ๐Ÿ”€ :: [#954, #955] ๋ถˆํ•„์š” ๋กœ์ง ์ œ๊ฑฐ Aug 2, 2024
@KangTaeHoon KangTaeHoon changed the title ๐Ÿ”€ :: [#954, #955] ๋ถˆํ•„์š” ๋กœ์ง ์ œ๊ฑฐ ๐Ÿ”€ :: (#954, #955) ๋ถˆํ•„์š” ๋กœ์ง ์ œ๊ฑฐ Aug 2, 2024
@baekteun baekteun added 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ โšก๏ธ Performance ์„ฑ๋Šฅ ๊ฐœ์„  labels Aug 2, 2024
@KangTaeHoon KangTaeHoon merged commit 8d0efe2 into develop Aug 2, 2024
3 checks passed
@KangTaeHoon KangTaeHoon deleted the 954-remove-unnecessary-logic branch August 2, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ ๊ธด๊ธ‰ โšก๏ธ Performance ์„ฑ๋Šฅ ๊ฐœ์„ 
Projects
None yet
3 participants