Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (876) μƒν˜Έμž‘μš©μ΄ μΌμ–΄λ‚˜λŠ” νŽ˜μ΄μ§€ 체크 #958

Merged
merged 4 commits into from
Aug 3, 2024
Merged

πŸ”€ :: (876) μƒν˜Έμž‘μš©μ΄ μΌμ–΄λ‚˜λŠ” νŽ˜μ΄μ§€ 체크 #958

merged 4 commits into from
Aug 3, 2024

Conversation

yongbeomkwak
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

μ„œλ‘œλ‹€λ₯Έ νƒ­μ—μ„œ μˆ˜μ •μ‚¬ν•­μ΄ 일어날 λ•Œ λ‹€λ₯Έ 탭에도 κ²°κ³Όκ°€ μ μš©λ˜μ•Όν•©λ‹ˆλ‹€.

Resolves 876μ΄μ§€λ§Œ λ‚¨μ•„μžˆλŠ” μž‘μ—…μ΄ μžˆμ–΄ λͺ…μ‹œλŠ” μ•ˆν•¨

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • 곑 λ‹΄κΈ° ν›„ 보관함에 반영
  • 곑 μ‚­μ œ ν›„ 보관함에 반영
  • ꡬ독 / κ΅¬λ…ν•΄μ œ μ‹œ 보관함에 반영
  • λ³΄κ΄€ν•¨μ—μ„œ μ‚­μ œ μ‹œ , ν”Œλ ˆμ΄λ¦¬μŠ€νŠΈ 상세 ꡬ독 μƒνƒœ λ³€κ²½
  • pivate 처리

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

κ΅¬ν˜„ μ‹œμ— κ³ λ―Όμ΄μ—ˆλ˜ 점듀 ν˜Ήμ€ νŠΉμ • 뢀뢄에 λŒ€ν•œ μ˜λ„κ°€ μžˆμ—ˆλ‹€λ©΄ PR 리뷰의 이해λ₯Ό 돕기 μœ„ν•΄ μ„œμˆ ν•΄μ£Όμ„Έμš”!

λ˜ν•œ λ¦¬λ·°μ–΄μ—κ²Œ νŠΉμ • 뢀뢄에 λŒ€ν•œ 집쀑 ν˜Ήμ€ μ½”λ©˜νŠΈ ν˜Ήμ€ μ§ˆλ¬Έμ„ μš”μ²­ν•˜λŠ” κ²½μš°μ— μž‘μ„±ν•˜λ©΄ μ’‹μ•„μš”!

e.g. μž‘μ—…μ„ 끝내야할 μ‹œκ°„μ΄ μ–Όλ§ˆ μ—†μ–΄ ν™•μž₯μ„±λ³΄λ‹€λŠ” λ™μž‘μ„ μœ„μ£Όλ‘œ λ§Œλ“€μ—ˆμ–΄μš”! κ°μ•ˆν•˜κ³  λ¦¬λ·°ν•΄μ£Όμ„Έμš”!

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

βœ… Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

βœ… Assign μžλ™ 지정을 μ„±κ³΅ν–ˆμ–΄μš”!

@yongbeomkwak

@yongbeomkwak yongbeomkwak merged commit db8838b into develop Aug 3, 2024
5 checks passed
@yongbeomkwak yongbeomkwak deleted the 876-check-refresh-interaction branch August 3, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@youn9k youn9k youn9k approved these changes

@baekteun baekteun baekteun approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

Assignees

@yongbeomkwak yongbeomkwak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yongbeomkwak @KangTaeHoon @youn9k @baekteun