-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lambda support to CHACallGraph #1476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liblit
requested changes
Nov 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I suggest a few minor tweaks to improve code and Javadoc style.
cast/src/main/java/com/ibm/wala/cast/ipa/cha/CrossLanguageClassHierarchy.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/ibm/wala/ipa/callgraph/cha/CHACallGraph.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/ibm/wala/ipa/callgraph/cha/CHACallGraph.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/ibm/wala/ipa/callgraph/cha/CHACallGraph.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/ibm/wala/ipa/callgraph/cha/CHACallGraph.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/ibm/wala/ipa/summaries/LambdaMethodTargetSelector.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/ibm/wala/ipa/summaries/LambdaMethodTargetSelector.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben Liblit <[email protected]>
Thanks for the detailed review! All suggestions applied. |
liblit
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1459
To support lambdas, we re-use logic from the
LambdaMethodTargetSelector
to handle calls that useinvokedynamic
.CHACallGraph
only includes edges for methods reachable from given entrypoints, and our handling of lambdas adds new synthetic classes to the class hierarchy (representing the classes generated for lambdas). So to ensure a complete call graph, we do a second pass after adding these synthetic classes to recompute call targets. This is probably not the most efficient way to do things, but I'm not sure it's the bottleneck; if we need to optimize in the future we should do so based on profiling.Note that the handling of lambdas here is very imprecise; every call site of a functional interface method will have an edge to every lambda of that functional interface type. Still, it could be practically useful, e.g., when combined with other heuristic filtering of irrelevant code.
We add new tests, and also fix a couple other minor bugs (e.g., there was no edge before to the synthetic method that invokes class initializers, so it wasn't being processed properly).