Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removing enableAdminAPI from wandb chart's values.yaml #238

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions charts/wandb/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ apiVersion: v2
name: wandb
description: A Helm chart for deploying W&B to Kubernetes
type: application
version: 0.3.8
version: 0.3.9
appVersion: 0.60.0
icon: https://wandb.ai/logo.svg
maintainers:
- name: wandb
email: [email protected]
url: https://wandb.com
- name: wandb
email: [email protected]
url: https://wandb.com
9 changes: 0 additions & 9 deletions charts/wandb/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,6 @@ spec:
- name: GORILLA_DISABLE_SSO_PROVISIONING
value: "{{ not .Values.sso.autoProvision }}"
{{- end}}
{{- if .Values.enableAdminApi }}
- name: GLOBAL_ADMIN_API_KEY
valueFrom:
secretKeyRef:
name: {{ include "wandb.fullname" . }}-secrets
key: ADMIN_API_KEY
- name: GORILLA_INSECURE_ALLOW_API_KEY_ADMIN_ACCESS
value: "true"
{{- end }}
- name: WANDB_HELM_CHART
value: {{ include "wandb.fullname" . }}:{{ .Chart.Version }}
{{- if .Values.smtpServer }}
Expand Down
17 changes: 7 additions & 10 deletions charts/wandb/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ image:

# Required for production environments
license:
# If set to true we'll provision an admin user and allow admin api access
enableAdminApi: false
# If using S3 be sure the pod has valid IAM creds, if using minio
# you can include the creds in the bucket url, i.e.
# !!! Be sure to use the externally accessible host / ingress,
Expand Down Expand Up @@ -104,15 +102,14 @@ ldap:
ingress:
enabled: false
className: ""
annotations:
{}
# kubernetes.io/ingress.class: nginx
# kubernetes.io/tls-acme: "true"
annotations: {}
# kubernetes.io/ingress.class: nginx
# kubernetes.io/tls-acme: "true"
hosts:
- host: wandb.mycompany.net
paths:
- path: /
pathType: ImplementationSpecific
- host: wandb.mycompany.net
paths:
- path: /
pathType: ImplementationSpecific
tls: []
# - secretName: chart-example-tls
# hosts:
Expand Down
Loading