feat(kms): Add support for kms key rotation

[CandiedCode]

• Address TFLint fixible issues
• terraform_deprecated_index
• terraform_unused_declarations
• terraform_deprecated_interpolation
• Update terraform docs
• Address KMS Rotation
• Add support for Make targets

[gls4]

Thank you for the PR! These changes look good to me. I've got to test them thoroughly before we can merge them in. More to come on that.

[gls4]

I'm running into cyclic dependency errors when applying these changes:

Error: Cycle: module.wandb_infra.module.networking.module.vpc.local.create_database_subnets (expand), module.wandb_infra.module.networking.module.vpc.output.database_subnets_cidr_blocks (expand), module.wandb_infra.module.networking.output.database_subnet_cidrs (expand), module.wandb_infra.local.network_database_subnet_cidrs (expand), module.wandb_infra.module.networking.var.database_subnet_cidrs (expand), module.wandb_infra.module.networking.module.vpc.var.database_subnets (expand), module.wandb_infra.module.networking.module.vpc.local.len_database_subnets (expand), module.wandb_infra.module.networking.module.vpc.aws_subnet.database

I've not been able to isolate where just yet -- have you been able to successfully build out a cluster using this code?

[CandiedCode]

@gls4 do you get the cyclic error on main as well or is this new to this branch?

I already had existing infrastructure, so I didn't use these modules.

[gls4]

@gls4 do you get the cyclic error on main as well or is this new to this branch?

I already had existing infrastructure, so I didn't use these modules.

Hi! I'm getting this on new infra as well as existing.