Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kms): Add support for kms key rotation #133

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(kms): Add support for kms key rotation #133

wants to merge 6 commits into from

Conversation

CandiedCode
Copy link

@CandiedCode CandiedCode commented Aug 31, 2023 •
edited
Loading

  • Address TFLint fixible issues
  • terraform_deprecated_index
  • terraform_unused_declarations
  • terraform_deprecated_interpolation
  • Update terraform docs
  • Address KMS Rotation
  • Add support for Make targets

@CandiedCode
style(lint): 🚨 Address tflint issues
15bae44 
This included terraform_deprecated_index, terraform_unused_declarations, and terraform_deprecated_interpolation..
@CandiedCode
docs(terraform-docs): 📝 update tfdocs
3909531
@CandiedCode
chore(security): 🔒 support enable_key_rotation for kms keys
ba37b44
@CandiedCode CandiedCode requested a review from gls4 as a code owner August 31, 2023 13:27
@CandiedCode CandiedCode requested a review from a team August 31, 2023 13:27
@CandiedCode CandiedCode changed the title Lint all the things feat(kms): add support for kms key rotation Aug 31, 2023
@gls4 gls4 changed the title feat(kms): add support for kms key rotation feat(kms): Add support for kms key rotation Aug 31, 2023
gls4
gls4 reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@gls4 gls4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! These changes look good to me. I've got to test them thoroughly before we can merge them in. More to come on that.

gls4
gls4 suggested changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@gls4 gls4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running into cyclic dependency errors when applying these changes:

Error: Cycle: module.wandb_infra.module.networking.module.vpc.local.create_database_subnets (expand), module.wandb_infra.module.networking.module.vpc.output.database_subnets_cidr_blocks (expand), module.wandb_infra.module.networking.output.database_subnet_cidrs (expand), module.wandb_infra.local.network_database_subnet_cidrs (expand), module.wandb_infra.module.networking.var.database_subnet_cidrs (expand), module.wandb_infra.module.networking.module.vpc.var.database_subnets (expand), module.wandb_infra.module.networking.module.vpc.local.len_database_subnets (expand), module.wandb_infra.module.networking.module.vpc.aws_subnet.database

I've not been able to isolate where just yet -- have you been able to successfully build out a cluster using this code?

@CandiedCode
Copy link
Author

@gls4 do you get the cyclic error on main as well or is this new to this branch?

I already had existing infrastructure, so I didn't use these modules.

@gls4
Copy link
Contributor

gls4 commented Sep 18, 2023

@gls4 do you get the cyclic error on main as well or is this new to this branch?

I already had existing infrastructure, so I didn't use these modules.

Hi! I'm getting this on new infra as well as existing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gls4 gls4 gls4 requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CandiedCode @gls4